zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Clean up some code quality issues

Browse source 
This removes some qualifiers that aren't necessary (e.g. public/abstract on interfaces, private on enum constructors, final on private methods, static on nested interfaces/enums), uses Java 8 lambdas and features where that's an improvement

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=177182945
This commit is contained in:
mcilwain 2017-11-28 10:35:57 -08:00 • committed by jianglai
parent 0935ba6450
commit e2db3f914e
109 changed files with 286 additions and 379 deletions
Download patch file Download diff file Expand all files Collapse all files

10
java/google/registry/groups/GroupsConnection.java
View file

@ -25,7 +25,7 @@ import java.util.Set;
public interface GroupsConnection {
/** The role of a member in a group. */
public enum Role {
enum Role {
MEMBER,
MANAGER,
OWNER
@ -36,19 +36,19 @@ public interface GroupsConnection {
* member already exists in the group, then it returns normally. If the group doesn't exist, then
* it is created.
*/
public void addMemberToGroup(String groupKey, String email, Role role) throws IOException;
void addMemberToGroup(String groupKey, String email, Role role) throws IOException;
/**
* Removes a member from the specified group, or throws {@link GoogleJsonResponseException} if the
* member doesn't exist.
*/
public void removeMemberFromGroup(String groupKey, String email) throws IOException;
void removeMemberFromGroup(String groupKey, String email) throws IOException;
/**
* Returns all of the members of the specified group. Note that it gets members only; not owners
* or managers. Returns an empty set if the group in question does not exist.
*/
public Set<String> getMembersOfGroup(String groupKey) throws IOException;
Set<String> getMembersOfGroup(String groupKey) throws IOException;
/**
* Creates a group with the given email address (groupKey) that is open for external members to
@ -57,5 +57,5 @@ public interface GroupsConnection {
* including permissions on who is able to join). The configured admin owner for the Google App is
* automatically added as an owner.
*/
public Group createGroup(String groupKey) throws IOException;
Group createGroup(String groupKey) throws IOException;
}