Add schema_deployer SQL user to SecretManager (#1018)

* Add schema_deployer SQL user to SecretManager

Add the 'schema_deployer' user to the SecretManager so that its
credential can be set up. The schema deployment process will use this
user instead of the 'postgres' user.

Changed the output of the get_sql_credential command for the schema
deployment process.

Added a sql script that documents the privileges granted to
'schema_deployer'.
This commit is contained in:
Weimin Yu 2021-03-17 19:31:44 -04:00 committed by GitHub
parent 127ae08790
commit deb84cf74d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 40 additions and 3 deletions

View file

@ -49,6 +49,7 @@ public abstract class SqlUser {
/** Enumerates the {@link RobotUser RobotUsers} in the system. */
public enum RobotId {
NOMULUS,
SCHEMA_DEPLOYER,
/**
* Credential for RegistryTool. This is temporary, and will be removed when tool users are
* assigned their personal credentials.

View file

@ -17,6 +17,7 @@ package google.registry.tools;
import com.beust.jcommander.Parameter;
import com.beust.jcommander.Parameters;
import com.google.common.base.Ascii;
import google.registry.config.RegistryConfig.Config;
import google.registry.privileges.secretmanager.SecretManagerClient.SecretManagerException;
import google.registry.privileges.secretmanager.SqlCredential;
import google.registry.privileges.secretmanager.SqlCredentialStore;
@ -31,13 +32,19 @@ import javax.inject.Inject;
/**
* Command to get a Cloud SQL credential in the Secret Manager.
*
* <p>This command is a short-term tool that will be deprecated by the planned privilege server.
* <p>The schema deployment process will use this command's output. Coordinate with <a
* href="https://github.com/google/nomulus/release/cloudbuild-schema-deploy.yaml">the schema
* deployment script</a> before making changes to the output.
*/
@Parameters(separators = " =", commandDescription = "Get the Cloud SQL Credential for a given user")
public class GetSqlCredentialCommand implements Command {
@Inject SqlCredentialStore store;
@Inject
@Config("cloudSqlInstanceConnectionName")
String cloudSqlInstanceConnectionName;
@Parameter(names = "--user", description = "The Cloud SQL user.", required = true)
private String user;
@ -62,12 +69,17 @@ public class GetSqlCredentialCommand implements Command {
return;
}
// Output format is important. Check class level javadoc before making changes.
String outputText =
String.format(
"%s %s %s", cloudSqlInstanceConnectionName, credential.login(), credential.password());
if (outputPath == null) {
System.out.printf("[%s]\n", credential.toFormattedString());
System.out.printf(outputText);
return;
}
try (FileOutputStream out = new FileOutputStream(outputPath.toFile())) {
out.write(credential.toFormattedString().getBytes(StandardCharsets.UTF_8));
out.write(outputText.getBytes(StandardCharsets.UTF_8));
}
}
}