zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-28 07:02:00 +02:00
Code Issues Projects Releases Packages Wiki Activity

Don't add all claims data to NORDN verify task

Browse source 
This claims data can exceed the maximum size of a task, causing the NORDN upload
to error out.  It also wasn't even being used anyway. This data is already
logged during the upload and there's no reason to log it as well during the
verify, because there is already a unique actionLogId that can be used to tie
the verify task back to the upload task.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=196521160
This commit is contained in:
mcilwain 2018-05-14 09:50:52 -07:00 • committed by jianglai
parent c25f765fc5
commit de5645abd9
5 changed files with 5 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

6
javatests/google/registry/tmch/NordnUploadActionTest.java
View file

@ -167,8 +167,7 @@ public class NordnUploadActionTest {
assertTasksEnqueued(NordnVerifyAction.QUEUE, new TaskMatcher()
.url(NordnVerifyAction.PATH)
.header(NordnVerifyAction.URL_HEADER, LOCATION_URL)
.header(CONTENT_TYPE, FORM_DATA.toString())
.param(NordnVerifyAction.PARAM_CSV_DATA, CLAIMS_CSV));
.header(CONTENT_TYPE, FORM_DATA.toString()));
}
@Test
@ -185,8 +184,7 @@ public class NordnUploadActionTest {
assertTasksEnqueued(NordnVerifyAction.QUEUE, new TaskMatcher()
.url(NordnVerifyAction.PATH)
.header(NordnVerifyAction.URL_HEADER, LOCATION_URL)
.header(CONTENT_TYPE, FORM_DATA.toString())
.param(NordnVerifyAction.PARAM_CSV_DATA, SUNRISE_CSV));
.header(CONTENT_TYPE, FORM_DATA.toString()));
}
@Test

7
javatests/google/registry/tmch/NordnVerifyActionTest.java
View file

@ -52,12 +52,6 @@ import org.mockito.Mock;
@RunWith(JUnit4.class)
public class NordnVerifyActionTest {
private static final String CSV_DATA = "1,2012-08-16T00:00:00.0Z,3\n"
+ "roid,domain-name,SMD-id,registrar-id,registration-datetime,application-datetime\n"
+ "SH8013-REP,example1.gtld,1-2,9999,2012-08-15T13:20:00.0Z,2012-07-15T00:50:00.0Z\n"
+ "EK77-REP,example2.gtld,2-2,9999,2012-08-15T14:00:03.0Z\n"
+ "HB800-REP,example3.gtld,3-2,9999,2012-08-15T15:40:00.0Z\n";
private static final String LOG_ACCEPTED = "1,2012-08-16T02:15:00.0Z,2012-08-16T00:00:00.0Z,"
+ "0000000000000478Nzs+3VMkR8ckuUynOLmyeqTmZQSbzDuf/R50n2n5QX4=,accepted,no-warnings,1\n"
+ "roid,result-code\n"
@ -105,7 +99,6 @@ public class NordnVerifyActionTest {
persistResource(Registry.get("gtld").asBuilder().setLordnUsername("lolcat").build());
lordnRequestInitializer.marksdbLordnPassword = Optional.of("attack");
action.tld = "gtld";
action.csvData = CSV_DATA;
action.fetchService = fetchService;
action.lordnRequestInitializer = lordnRequestInitializer;
action.response = response;