Add [] to export domain lists to GCS

The ExportDomainListsAction [] has a cron entry that runs it twice per day.  It exports one flat text file per real (non-test) TLD to the "{project-id}-domain-lists" bucket in Google Cloud Storage, overwriting the existing ones in place.  Each file is a newline-delimited list of active (non-deleted) domains in that TLD.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=116767987

javatests/com/google/domain/registry/export/BUILD

@@ -26,11 +26,13 @@ java_library(
         "//java/com/google/domain/registry/export",
         "//java/com/google/domain/registry/gcs",
         "//java/com/google/domain/registry/groups",
+        "//java/com/google/domain/registry/mapreduce",
         "//java/com/google/domain/registry/model",
         "//java/com/google/domain/registry/request",
         "//java/com/google/domain/registry/storage/drive",
         "//java/com/google/domain/registry/util",
         "//javatests/com/google/domain/registry/testing",
+        "//javatests/com/google/domain/registry/testing/mapreduce",
         "//third_party/java/appengine:appengine-api-testonly",
         "//third_party/java/appengine:appengine-stubs",
         "//third_party/java/appengine_gcs_client",

javatests/com/google/domain/registry/export/ExportDomainListsActionTest.java

@@ -0,0 +1,138 @@
+// Copyright 2016 Google Inc. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.google.domain.registry.export;
+
+import static com.google.appengine.tools.cloudstorage.GcsServiceFactory.createGcsService;
+import static com.google.common.truth.Truth.assertThat;
+import static com.google.domain.registry.testing.DatastoreHelper.createTld;
+import static com.google.domain.registry.testing.DatastoreHelper.persistActiveDomain;
+import static com.google.domain.registry.testing.DatastoreHelper.persistActiveDomainApplication;
+import static com.google.domain.registry.testing.DatastoreHelper.persistDeletedDomain;
+import static com.google.domain.registry.testing.DatastoreHelper.persistResource;
+import static com.google.domain.registry.testing.GcsTestingUtils.readGcsFile;
+import static java.nio.charset.StandardCharsets.UTF_8;
+
+import com.google.appengine.tools.cloudstorage.GcsFilename;
+import com.google.appengine.tools.cloudstorage.GcsService;
+import com.google.appengine.tools.cloudstorage.ListOptions;
+import com.google.appengine.tools.cloudstorage.ListResult;
+import com.google.common.base.Optional;
+import com.google.common.base.Splitter;
+import com.google.domain.registry.mapreduce.MapreduceRunner;
+import com.google.domain.registry.model.registry.Registry;
+import com.google.domain.registry.model.registry.Registry.TldType;
+import com.google.domain.registry.testing.ExceptionRule;
+import com.google.domain.registry.testing.FakeResponse;
+import com.google.domain.registry.testing.mapreduce.MapreduceTestCase;
+
+import org.joda.time.DateTime;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+import java.io.FileNotFoundException;
+
+/** Unit tests for {@link ExportDomainListsAction}. */
+@RunWith(JUnit4.class)
+public class ExportDomainListsActionTest extends MapreduceTestCase<ExportDomainListsAction> {
+
+  private GcsService gcsService;
+
+  @Rule
+  public final ExceptionRule thrown = new ExceptionRule();
+
+  @Before
+  public void init() {
+    createTld("tld");
+    createTld("testtld");
+    persistResource(Registry.get("testtld").asBuilder().setTldType(TldType.TEST).build());
+
+    action = new ExportDomainListsAction();
+    action.mrRunner = new MapreduceRunner(Optional.<Integer>absent(), Optional.<Integer>absent());
+    action.response = new FakeResponse();
+    action.gcsBucket = "outputbucket";
+    action.gcsBufferSize = 500;
+    gcsService = createGcsService();
+  }
+
+  private void runMapreduce() throws Exception {
+    action.run();
+    executeTasksUntilEmpty("mapreduce");
+  }
+
+  @Test
+  public void test_outputsOnlyActiveDomains() throws Exception {
+    persistActiveDomain("onetwo.tld");
+    persistActiveDomain("rudnitzky.tld");
+    persistDeletedDomain("mortuary.tld", DateTime.parse("2001-03-14T10:11:12Z"));
+    runMapreduce();
+    GcsFilename existingFile = new GcsFilename("outputbucket", "tld.txt");
+    String tlds = new String(readGcsFile(gcsService, existingFile), UTF_8).trim();
+    // Check that it only contains the active domains, not the dead one.
+    assertThat(Splitter.on('\n').splitToList(tlds)).containsExactly("onetwo.tld", "rudnitzky.tld");
+  }
+
+  @Test
+  public void test_outputsOnlyDomainsOnRealTlds() throws Exception {
+    persistActiveDomain("onetwo.tld");
+    persistActiveDomain("rudnitzky.tld");
+    persistActiveDomain("wontgo.testtld");
+    runMapreduce();
+    GcsFilename existingFile = new GcsFilename("outputbucket", "tld.txt");
+    String tlds = new String(readGcsFile(gcsService, existingFile), UTF_8).trim();
+    // Check that it only contains the domains on the real TLD, and not the test one.
+    assertThat(Splitter.on('\n').splitToList(tlds)).containsExactly("onetwo.tld", "rudnitzky.tld");
+    // Make sure that the test TLD file wasn't written out.
+    GcsFilename nonexistentFile = new GcsFilename("outputbucket", "testtld.txt");
+    thrown.expect(FileNotFoundException.class);
+    readGcsFile(gcsService, nonexistentFile);
+    ListResult ls = gcsService.list("outputbucket", ListOptions.DEFAULT);
+    assertThat(ls.next().getName()).isEqualTo("tld.txt");
+    // Make sure that no other files were written out.
+    assertThat(ls.hasNext()).isFalse();
+  }
+
+  @Test
+  public void test_outputsDomainsFromDifferentTldsToMultipleFiles() throws Exception {
+    createTld("tldtwo");
+    // You'd think this test was written around Christmas, but it wasn't.
+    persistActiveDomain("dasher.tld");
+    persistActiveDomain("prancer.tld");
+    persistActiveDomain("rudolph.tldtwo");
+    persistActiveDomain("santa.tldtwo");
+    persistActiveDomain("buddy.tldtwo");
+    runMapreduce();
+    GcsFilename firstTldFile = new GcsFilename("outputbucket", "tld.txt");
+    String tlds = new String(readGcsFile(gcsService, firstTldFile), UTF_8).trim();
+    assertThat(Splitter.on('\n').splitToList(tlds)).containsExactly("dasher.tld", "prancer.tld");
+    GcsFilename secondTldFile = new GcsFilename("outputbucket", "tldtwo.txt");
+    String moreTlds = new String(readGcsFile(gcsService, secondTldFile), UTF_8).trim();
+    assertThat(Splitter.on('\n').splitToList(moreTlds))
+        .containsExactly("rudolph.tldtwo", "santa.tldtwo", "buddy.tldtwo");
+  }
+
+  @Test
+  public void test_doesntOutputDomainApplications() throws Exception {
+    persistActiveDomain("chilipepper.tld");
+    persistActiveDomainApplication("nagajolokia.tld");
+    runMapreduce();
+    GcsFilename firstTldFile = new GcsFilename("outputbucket", "tld.txt");
+    String tlds = new String(readGcsFile(gcsService, firstTldFile), UTF_8).trim();
+    // Check that it didn't output nagajolokia.tld.
+    assertThat(Splitter.on('\n').splitToList(tlds)).containsExactly("chilipepper.tld");
+  }
+}

javatests/com/google/domain/registry/testing/DatastoreHelper.java

@@ -286,8 +286,7 @@ public class DatastoreHelper {
   }
 
   public static DomainResource persistDomainAsDeleted(DomainResource domain, DateTime now) {
-    return persistResource(
-        domain.asBuilder().setDeletionTime(now.minusDays(1)).build());
+    return persistResource(domain.asBuilder().setDeletionTime(now.minusDays(1)).build());
   }
 
   /** Persists a domain and enqueues a LORDN task of the appropriate type for it. */