From db932fe3362d2ae7a636cbb6496824f9f4b9c5fb Mon Sep 17 00:00:00 2001 From: Gus Brodman Date: Thu, 13 Jun 2019 18:04:57 -0400 Subject: [PATCH] Add more tests in RegistrarTest --- .../model/registrar/RegistrarTest.java | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/core/src/test/java/google/registry/model/registrar/RegistrarTest.java b/core/src/test/java/google/registry/model/registrar/RegistrarTest.java index 9fa471426..67a28c541 100644 --- a/core/src/test/java/google/registry/model/registrar/RegistrarTest.java +++ b/core/src/test/java/google/registry/model/registrar/RegistrarTest.java @@ -469,6 +469,16 @@ public class RegistrarTest extends EntityTestCase { .isEqualTo("Provided email lolcat is not a valid email address"); } + @Test + public void testFailure_emptyEmail() { + IllegalArgumentException thrown = + assertThrows( + IllegalArgumentException.class, () -> registrar.asBuilder().setEmailAddress("")); + assertThat(thrown) + .hasMessageThat() + .isEqualTo("Provided email is not a valid email address"); + } + @Test public void testFailure_nullIcannReferralEmail() { NullPointerException thrown = @@ -478,7 +488,7 @@ public class RegistrarTest extends EntityTestCase { } @Test - public void testFailure_invalidIcannEmail() { + public void testFailure_invalidIcannReferralEmail() { IllegalArgumentException thrown = assertThrows( IllegalArgumentException.class, @@ -488,6 +498,16 @@ public class RegistrarTest extends EntityTestCase { .isEqualTo("Provided email lolcat is not a valid email address"); } + @Test + public void testFailure_emptyIcannReferralEmail() { + IllegalArgumentException thrown = + assertThrows( + IllegalArgumentException.class, () -> registrar.asBuilder().setEmailAddress("")); + assertThat(thrown) + .hasMessageThat() + .isEqualTo("Provided email is not a valid email address"); + } + @Test public void testSuccess_setAllowedTldsUncached_newTldNotInCache() { int origSingletonCacheRefreshSeconds =