zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 16:37:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Improve RDE error logging

Browse source 
RDE logs somewhat inscrutable errors when XML validation of the output fails due to bad data in Datastore. This CL adds a little more information to help us track down this sort of problem in the future.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=140872462
This commit is contained in:
mountford 2016-12-02 11:21:24 -08:00 • committed by Ben McIlwain
parent f227598920
commit da711343f0
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/rde/RdeMarshaller.java
View file

@ -148,7 +148,7 @@ public final class RdeMarshaller implements Serializable {
Key.create(resource), Key.create(resource),
e.getLinkedException(), e.getLinkedException(),
getMarshaller().marshalLenient(element)); getMarshaller().marshalLenient(element));
logger.severe(error); logger.severe(e, error);
} }
return DepositFragment.create(type, xml, error); return DepositFragment.create(type, xml, error);
} }

2
java/google/registry/rde/RdeStagingReducer.java
View file

@ -162,7 +162,7 @@ public final class RdeStagingReducer extends Reducer<PendingDeposit, DepositFrag
} }
// If an entity was broken, abort after writing as much logs/deposit data as possible. // If an entity was broken, abort after writing as much logs/deposit data as possible.
verify(!failed); verify(!failed, "RDE staging failed for TLD %s", tld);
// Write a file to GCS containing the byte length (ASCII) of the raw unencrypted XML. // Write a file to GCS containing the byte length (ASCII) of the raw unencrypted XML.
// //