mirror of
https://github.com/google/nomulus.git
synced 2025-07-05 18:53:34 +02:00
Remove unused and misused methods from EppResourceUtils and DomainBase.
The methods in DomainBase were the only callers for the methods in EppResourceUtils, so I first inlined them. Then I realized that there were no callers for loadReferencedContacts() anywhere. For loadNameservers(), all but one invocation actually wanted to load the foreign keys, and was repeating that work, so I replaced it with loadNameserverFullyQualifiedHostNames(). The last invocation, in the Rdap code, was incorrectly assuming this was an async load when in fact it blocks, so I replaced it with a real async load. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=122433897
This commit is contained in:
parent
9a2afc7a9b
commit
d9875ea302
8 changed files with 31 additions and 60 deletions
|
@ -16,6 +16,7 @@ package google.registry.dns.writer.dnsupdate;
|
|||
|
||||
import static com.google.common.base.Verify.verify;
|
||||
import static google.registry.model.EppResourceUtils.loadByUniqueId;
|
||||
import static google.registry.model.ofy.ObjectifyService.ofy;
|
||||
|
||||
import com.google.common.net.InternetDomainName;
|
||||
|
||||
|
@ -102,7 +103,8 @@ public class DnsUpdateWriter implements DnsWriter {
|
|||
Update update = new Update(toAbsoluteName(findTldFromName(domainName)));
|
||||
update.delete(toAbsoluteName(domainName), Type.ANY);
|
||||
if (domain != null && domain.shouldPublishToDns()) {
|
||||
update.add(makeNameServerSet(domainName, domain.loadNameservers()));
|
||||
update.add(makeNameServerSet(
|
||||
domainName, ofy().load().refs(domain.getNameservers()).values()));
|
||||
update.add(makeDelegationSignerSet(domainName, domain.getDsData()));
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue