zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Truncate how much info we log about updated premium lists

Browse source 
It doesn't make sense to log all 10K+ lines of a premium list every time it's
updated, and indeed that seems to hurt performance, yet that's precisely what
we were doing.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=194449836
This commit is contained in:
mcilwain 2018-04-26 14:01:20 -07:00 • committed by jianglai
parent 4657b8ab51
commit d95f286e58
3 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
java/google/registry/tools/server/CreateOrUpdatePremiumListAction.java
View file

@ -18,6 +18,7 @@ import com.google.common.collect.ImmutableMap;
import google.registry.request.JsonResponse;
import google.registry.request.Parameter;
import google.registry.util.FormattingLogger;
import java.util.logging.Level;
import javax.inject.Inject;
/**
@ -27,6 +28,8 @@ public abstract class CreateOrUpdatePremiumListAction implements Runnable {
protected static final FormattingLogger logger = FormattingLogger.getLoggerForCallerClass();
private static final int MAX_LOGGING_PREMIUM_LIST_LENGTH = 1000;
public static final String NAME_PARAM = "name";
public static final String INPUT_PARAM = "inputData";
@ -47,6 +50,17 @@ public abstract class CreateOrUpdatePremiumListAction implements Runnable {
}
}
/** Logs the premium list data at INFO, truncated if too long. */
void logInputData() {
if (logger.isLoggable(Level.INFO)) {
logger.infofmt(
"Received the following input data: %s",
(inputData.length() < MAX_LOGGING_PREMIUM_LIST_LENGTH)
? inputData
: (inputData.substring(0, MAX_LOGGING_PREMIUM_LIST_LENGTH) + "<truncated>"));
}
}
/** Creates a new premium list or updates an existing one. */
protected abstract void savePremiumList();
}

2
java/google/registry/tools/server/CreatePremiumListAction.java
View file

@ -55,7 +55,7 @@ public class CreatePremiumListAction extends CreateOrUpdatePremiumListAction {
}
logger.infofmt("Saving premium list for TLD %s", name);
logger.infofmt("Got the following input data: %s", inputData);
logInputData();
List<String> inputDataPreProcessed =
Splitter.on('\n').omitEmptyStrings().splitToList(inputData);
PremiumList premiumList = new PremiumList.Builder().setName(name).build();

2
java/google/registry/tools/server/UpdatePremiumListAction.java
View file

@ -51,7 +51,7 @@ public class UpdatePremiumListAction extends CreateOrUpdatePremiumListAction {
name);
logger.infofmt("Updating premium list for TLD %s", name);
logger.infofmt("Got the following input data: %s", inputData);
logInputData();
List<String> inputDataPreProcessed =
Splitter.on('\n').omitEmptyStrings().splitToList(inputData);
PremiumList newPremiumList =