zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 08:27:14 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove temporary handling of invalid billing events

Browse source 
The bad prober domain data has since been deleted, so we no longer need
to handle the case where these Keys point to entities that don't exist.

This mostly reverses []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=168687701
This commit is contained in:
mcilwain 2017-09-14 07:50:54 -07:00 • committed by jianglai
parent efd7010f9d
commit d73ef66352
2 changed files with 1 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

14
javatests/google/registry/flows/domain/DomainDeleteFlowTest.java
View file

@ -511,20 +511,6 @@ public class DomainDeleteFlowTest extends ResourceFlowTestCase<DomainDeleteFlow,
assertThat(domain.getTransferData()).isEqualTo(TransferData.EMPTY);
}
//TODO(b/27472322): Delete test handling recurring being null once bad data is cleaned from prod.
@Test
public void testSuccess_nullAutorenewBillingEvent_isIgnore() throws Exception {
setClientIdForFlow("TheRegistrar");
setUpSuccessfulTest();
ofy().deleteWithoutBackup().key(domain.getAutorenewBillingEvent()).now();
ofy().clearSessionCache();
clock.advanceOneMilli();
runFlowAssertResponse(readFile("domain_delete_response_pending.xml"));
// If the previous statement doesn't throw an error, then the test is successful.
assertThat(ofy().load().key(reloadResourceByForeignKey().getAutorenewBillingEvent()).now())
.isNull();
}
@Test
public void testSuccess_pendingTransfer() throws Exception {
setClientIdForFlow("TheRegistrar");