From d54d546ea37d21af72dbca179a6d70a1d35621fd Mon Sep 17 00:00:00 2001 From: jianglai Date: Tue, 20 Mar 2018 01:11:32 -0700 Subject: [PATCH] Replace occurrences of Wrapped.valueOf(...) with Wrapped.parseWrapped(...) where the value will be immediately unboxed anyway. The change removes small-but-pervasive inefficiencies from creating and immediately discarding instances of the wrapped value, as well as removing unnecessary syntax. More information: [] Tested: TAP --sample for global presubmit queue [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=189704431 --- java/google/registry/batch/DeleteContactsAndHostsAction.java | 2 +- java/google/registry/request/RequestParameters.java | 2 +- java/google/registry/tldconfig/idn/IdnTable.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/java/google/registry/batch/DeleteContactsAndHostsAction.java b/java/google/registry/batch/DeleteContactsAndHostsAction.java index c424a79b8..7ba336454 100644 --- a/java/google/registry/batch/DeleteContactsAndHostsAction.java +++ b/java/google/registry/batch/DeleteContactsAndHostsAction.java @@ -501,7 +501,7 @@ public class DeleteContactsAndHostsAction implements Runnable { checkNotNull( params.get(PARAM_SERVER_TRANSACTION_ID), "Server transaction id not specified")) .setIsSuperuser( - Boolean.valueOf( + Boolean.parseBoolean( checkNotNull(params.get(PARAM_IS_SUPERUSER), "Is superuser not specified"))) .setRequestedTime( DateTime.parse( diff --git a/java/google/registry/request/RequestParameters.java b/java/google/registry/request/RequestParameters.java index bbd7da310..e24b4317a 100644 --- a/java/google/registry/request/RequestParameters.java +++ b/java/google/registry/request/RequestParameters.java @@ -84,7 +84,7 @@ public final class RequestParameters { */ public static int extractIntParameter(HttpServletRequest req, String name) { try { - return Integer.valueOf(nullToEmpty(req.getParameter(name))); + return Integer.parseInt(nullToEmpty(req.getParameter(name))); } catch (NumberFormatException e) { throw new BadRequestException("Expected integer: " + name); } diff --git a/java/google/registry/tldconfig/idn/IdnTable.java b/java/google/registry/tldconfig/idn/IdnTable.java index 43a96d3ad..7e8a44c92 100644 --- a/java/google/registry/tldconfig/idn/IdnTable.java +++ b/java/google/registry/tldconfig/idn/IdnTable.java @@ -137,6 +137,6 @@ public final class IdnTable { checkArgument(matcher.lookingAt(), "Can't parse line: %s", line); String hexString = matcher.group(1); - return Integer.valueOf(hexString, 16); + return Integer.parseInt(hexString, 16); } }