zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-14 13:34:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

Enable Test Executor sharing again in Gradle build

Browse source 
Identified a few more tests that are impacted by test cleanup
issues outside of Nomulus code base, more likely thread pool
cleanup behaviors in AppEngine testing fixture.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=229934266
This commit is contained in:
weiminyu 2019-01-18 08:40:46 -08:00 • committed by Ben McIlwain
parent 52212748ca
commit d3e25cd5b1
1 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
gradle/core/build.gradle
View file

@ -11,6 +11,7 @@ def generatedDir = "${project.buildDir}/generated/source/custom/main"
// state) or victims. // state) or victims.
// TODO(weiminyu): identify cause and fix offending tests. // TODO(weiminyu): identify cause and fix offending tests.
def outcastTestPatterns = [ def outcastTestPatterns = [
// Problem seems to lie with AppEngine TaskQueue for test.
"google/registry/batch/DeleteContactsAndHostsActionTest.*", "google/registry/batch/DeleteContactsAndHostsActionTest.*",
"google/registry/batch/RefreshDnsOnHostRenameActionTest.*", "google/registry/batch/RefreshDnsOnHostRenameActionTest.*",
"google/registry/flows/CheckApiActionTest.*", "google/registry/flows/CheckApiActionTest.*",
@ -19,15 +20,19 @@ def outcastTestPatterns = [
"google/registry/flows/domain/DomainUpdateFlowTest.*", "google/registry/flows/domain/DomainUpdateFlowTest.*",
"google/registry/tools/CreateDomainCommandTest.*", "google/registry/tools/CreateDomainCommandTest.*",
"google/registry/tools/server/CreatePremiumListActionTest.*", "google/registry/tools/server/CreatePremiumListActionTest.*",
// Conflicts with WhoisActionTest
"google/registry/whois/WhoisHttpActionTest.*",
] ]
// Tests that conflict with members of both the main test suite and the // Tests that conflict with members of both the main test suite and the
// outcast suite. // outcast suite. They seem to be affected by global states outside of
// Nomulus classes, e.g., threads and objects retained by frameworks.
// TODO(weiminyu): identify cause and fix offending tests. // TODO(weiminyu): identify cause and fix offending tests.
def fragileTestPatterns = [ def fragileTestPatterns = [
"google/registry/cron/TldFanoutActionTest.*" // Problem seems to lie with AppEngine TaskQueue for test.
"google/registry/cron/TldFanoutActionTest.*",
// Test Datastore inexplicably aborts transaction.
"google/registry/model/tmch/ClaimsListShardTest.*",
// Creates large object (64MBytes), occasionally throws OOM error.
"google/registry/model/server/KmsSecretRevisionTest.*"
] ]
sourceSets { sourceSets {
@ -450,9 +455,9 @@ test {
exclude outcastTestPatterns exclude outcastTestPatterns
// Run every test class in its own process. // Run every test class in its own process.
// TODO: Figure out why we need to do this, fix it and then stop doing it. // Uncomment to unblock build while troubleshooting inexplicable test errors.
// This setting makes the build take 35 minutes, without it it takes about 10. // This setting makes the build take 35 minutes, without it it takes about 10.
forkEvery 1 // forkEvery 1
// Sets the maximum number of test executors that may exist at the same time. // Sets the maximum number of test executors that may exist at the same time.
maxParallelForks 5 maxParallelForks 5