Remove some unnecessary uses of MockitoJUnitRunner, which is discouraged

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=153589104
This commit is contained in:
mountford 2017-04-19 08:23:08 -07:00 committed by Ben McIlwain
parent fb25b625f3
commit d35be27b65
17 changed files with 97 additions and 152 deletions

View file

@ -21,6 +21,7 @@ import static google.registry.testing.TaskQueueHelper.assertNoTasksEnqueued;
import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued; import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued;
import static google.registry.util.DateTimeUtils.START_OF_TIME; import static google.registry.util.DateTimeUtils.START_OF_TIME;
import static org.joda.time.DateTimeZone.UTC; import static org.joda.time.DateTimeZone.UTC;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableMap;
@ -36,11 +37,10 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link CommitLogCheckpointAction}. */ /** Unit tests for {@link CommitLogCheckpointAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class CommitLogCheckpointActionTest { public class CommitLogCheckpointActionTest {
private static final String QUEUE_NAME = "export-commits"; private static final String QUEUE_NAME = "export-commits";
@ -51,8 +51,7 @@ public class CommitLogCheckpointActionTest {
.withTaskQueue() .withTaskQueue()
.build(); .build();
@Mock CommitLogCheckpointStrategy strategy = mock(CommitLogCheckpointStrategy.class);
CommitLogCheckpointStrategy strategy;
DateTime now = DateTime.now(UTC); DateTime now = DateTime.now(UTC);
CommitLogCheckpointAction task = new CommitLogCheckpointAction(); CommitLogCheckpointAction task = new CommitLogCheckpointAction();

View file

@ -39,10 +39,10 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.runners.MockitoJUnitRunner; import org.junit.runners.JUnit4;
/** Unit tests for {@link CommitLogCheckpointStrategy}. */ /** Unit tests for {@link CommitLogCheckpointStrategy}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class CommitLogCheckpointStrategyTest { public class CommitLogCheckpointStrategyTest {
@Rule @Rule

View file

@ -66,12 +66,11 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
import org.mockito.ArgumentCaptor; import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link VerifyEntityIntegrityAction}. */ /** Unit tests for {@link VerifyEntityIntegrityAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class VerifyEntityIntegrityActionTest public class VerifyEntityIntegrityActionTest
extends MapreduceTestCase<VerifyEntityIntegrityAction> { extends MapreduceTestCase<VerifyEntityIntegrityAction> {
@ -82,20 +81,13 @@ public class VerifyEntityIntegrityActionTest
private ArgumentCaptor<TableDataInsertAllRequest> rowsCaptor; private ArgumentCaptor<TableDataInsertAllRequest> rowsCaptor;
private final DateTime now = DateTime.parse("2012-01-02T03:04:05Z"); private final DateTime now = DateTime.parse("2012-01-02T03:04:05Z");
@Mock private final Bigquery bigquery = mock(Bigquery.class);
private Bigquery bigquery; private final Bigquery.Tabledata bigqueryTableData = mock(Bigquery.Tabledata.class);
private final Bigquery.Tabledata.InsertAll bigqueryInsertAll =
@Mock mock(Bigquery.Tabledata.InsertAll.class);
private Bigquery.Tabledata bigqueryTableData; private final BigqueryFactory bigqueryFactory = mock(BigqueryFactory.class);
private final VerifyEntityIntegrityStreamerFactory streamerFactory =
@Mock mock(VerifyEntityIntegrityStreamerFactory.class);
private Bigquery.Tabledata.InsertAll bigqueryInsertAll;
@Mock
private BigqueryFactory bigqueryFactory;
@Mock
private VerifyEntityIntegrityStreamerFactory streamerFactory;
@Before @Before
public void before() throws Exception { public void before() throws Exception {

View file

@ -19,6 +19,7 @@ import static google.registry.bigquery.BigqueryUtils.FieldType.STRING;
import static org.mockito.Matchers.any; import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyString; import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.eq; import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -35,31 +36,20 @@ import com.google.common.collect.ImmutableMap;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
import org.mockito.ArgumentCaptor; import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link BigqueryFactory}. */ /** Unit tests for {@link BigqueryFactory}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class BigqueryFactoryTest { public class BigqueryFactoryTest {
@Mock private final BigqueryFactory.Subfactory subfactory = mock(BigqueryFactory.Subfactory.class);
private BigqueryFactory.Subfactory subfactory; private final Bigquery bigquery = mock(Bigquery.class);
private final Bigquery.Datasets bigqueryDatasets = mock(Bigquery.Datasets.class);
@Mock private final Bigquery.Datasets.Insert bigqueryDatasetsInsert =
private Bigquery bigquery; mock(Bigquery.Datasets.Insert.class);
private final Bigquery.Tables bigqueryTables = mock(Bigquery.Tables.class);
@Mock private final Bigquery.Tables.Insert bigqueryTablesInsert = mock(Bigquery.Tables.Insert.class);
private Bigquery.Datasets bigqueryDatasets;
@Mock
private Bigquery.Datasets.Insert bigqueryDatasetsInsert;
@Mock
private Bigquery.Tables bigqueryTables;
@Mock
private Bigquery.Tables.Insert bigqueryTablesInsert;
private BigqueryFactory factory; private BigqueryFactory factory;

View file

@ -39,10 +39,10 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.runners.MockitoJUnitRunner; import org.junit.runners.JUnit4;
/** Unit tests for {@link PublishDnsUpdatesAction}. */ /** Unit tests for {@link PublishDnsUpdatesAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class PublishDnsUpdatesActionTest { public class PublishDnsUpdatesActionTest {
@Rule @Rule

View file

@ -38,8 +38,7 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
import org.xbill.DNS.ARecord; import org.xbill.DNS.ARecord;
import org.xbill.DNS.DClass; import org.xbill.DNS.DClass;
import org.xbill.DNS.Flags; import org.xbill.DNS.Flags;
@ -52,16 +51,13 @@ import org.xbill.DNS.Type;
import org.xbill.DNS.Update; import org.xbill.DNS.Update;
/** Unit tests for {@link DnsMessageTransport}. */ /** Unit tests for {@link DnsMessageTransport}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class DnsMessageTransportTest { public class DnsMessageTransportTest {
private static final String UPDATE_HOST = "127.0.0.1"; private static final String UPDATE_HOST = "127.0.0.1";
@Mock private final SocketFactory mockFactory = mock(SocketFactory.class);
private SocketFactory mockFactory; private final Socket mockSocket = mock(Socket.class);
@Mock
private Socket mockSocket;
private Message simpleQuery; private Message simpleQuery;
private Message expectedResponse; private Message expectedResponse;

View file

@ -22,6 +22,7 @@ import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued;
import static java.nio.charset.StandardCharsets.UTF_8; import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.logging.Level.INFO; import static java.util.logging.Level.INFO;
import static java.util.logging.Level.SEVERE; import static java.util.logging.Level.SEVERE;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import com.google.api.services.bigquery.Bigquery; import com.google.api.services.bigquery.Bigquery;
@ -57,11 +58,10 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link BigqueryPollJobAction}. */ /** Unit tests for {@link BigqueryPollJobAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class BigqueryPollJobActionTest { public class BigqueryPollJobActionTest {
@Rule @Rule
@ -73,16 +73,16 @@ public class BigqueryPollJobActionTest {
@Rule @Rule
public final ExceptionRule thrown = new ExceptionRule(); public final ExceptionRule thrown = new ExceptionRule();
@Mock Bigquery bigquery; private static final String PROJECT_ID = "project_id";
@Mock Bigquery.Jobs bigqueryJobs; private static final String JOB_ID = "job_id";
@Mock Bigquery.Jobs.Get bigqueryJobsGet; private static final String CHAINED_QUEUE_NAME = UpdateSnapshotViewAction.QUEUE;
private static final TaskEnqueuer ENQUEUER =
static final String PROJECT_ID = "project_id";
static final String JOB_ID = "job_id";
static final String CHAINED_QUEUE_NAME = UpdateSnapshotViewAction.QUEUE;
static final TaskEnqueuer ENQUEUER =
new TaskEnqueuer(new Retrier(new FakeSleeper(new FakeClock()), 1)); new TaskEnqueuer(new Retrier(new FakeSleeper(new FakeClock()), 1));
private final Bigquery bigquery = mock(Bigquery.class);
private final Bigquery.Jobs bigqueryJobs = mock(Bigquery.Jobs.class);
private final Bigquery.Jobs.Get bigqueryJobsGet = mock(Bigquery.Jobs.Get.class);
private final CapturingLogHandler logHandler = new CapturingLogHandler(); private final CapturingLogHandler logHandler = new CapturingLogHandler();
private BigqueryPollJobAction action = new BigqueryPollJobAction(); private BigqueryPollJobAction action = new BigqueryPollJobAction();
@ -139,7 +139,7 @@ public class BigqueryPollJobActionTest {
private void assertLogMessage(Level level, String message) { private void assertLogMessage(Level level, String message) {
for (LogRecord logRecord : logHandler.getRecords()) { for (LogRecord logRecord : logHandler.getRecords()) {
if (logRecord.getLevel() == level && logRecord.getMessage().contains(message)) { if (logRecord.getLevel().equals(level) && logRecord.getMessage().contains(message)) {
return; return;
} }
} }

View file

@ -19,6 +19,7 @@ import static google.registry.export.CheckSnapshotAction.CHECK_SNAPSHOT_KINDS_TO
import static google.registry.export.CheckSnapshotAction.CHECK_SNAPSHOT_NAME_PARAM; import static google.registry.export.CheckSnapshotAction.CHECK_SNAPSHOT_NAME_PARAM;
import static google.registry.testing.TaskQueueHelper.assertNoTasksEnqueued; import static google.registry.testing.TaskQueueHelper.assertNoTasksEnqueued;
import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued; import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import com.google.common.base.Joiner; import com.google.common.base.Joiner;
@ -41,11 +42,10 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link CheckSnapshotAction}. */ /** Unit tests for {@link CheckSnapshotAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class CheckSnapshotActionTest { public class CheckSnapshotActionTest {
static final DateTime START_TIME = DateTime.parse("2014-08-01T01:02:03Z"); static final DateTime START_TIME = DateTime.parse("2014-08-01T01:02:03Z");
@ -55,7 +55,7 @@ public class CheckSnapshotActionTest {
@Rule public final AppEngineRule appEngine = AppEngineRule.builder().withTaskQueue().build(); @Rule public final AppEngineRule appEngine = AppEngineRule.builder().withTaskQueue().build();
@Rule public final ExceptionRule thrown = new ExceptionRule(); @Rule public final ExceptionRule thrown = new ExceptionRule();
@Mock private DatastoreBackupService backupService; private final DatastoreBackupService backupService = mock(DatastoreBackupService.class);
private DatastoreBackupInfo backupInfo; private DatastoreBackupInfo backupInfo;

View file

@ -18,6 +18,7 @@ import static com.google.appengine.api.datastore.DatastoreServiceFactory.getData
import static com.google.common.collect.Iterables.transform; import static com.google.common.collect.Iterables.transform;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued; import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import com.google.appengine.api.datastore.Entity; import com.google.appengine.api.datastore.Entity;
@ -35,11 +36,10 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link DatastoreBackupService}. */ /** Unit tests for {@link DatastoreBackupService}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class DatastoreBackupServiceTest { public class DatastoreBackupServiceTest {
@Rule @Rule
@ -54,8 +54,7 @@ public class DatastoreBackupServiceTest {
.withTaskQueue() .withTaskQueue()
.build(); .build();
@Mock private final ModulesService modulesService = mock(ModulesService.class);
private ModulesService modulesService;
private static final DateTime START_TIME = DateTime.parse("2014-08-01T01:02:03Z"); private static final DateTime START_TIME = DateTime.parse("2014-08-01T01:02:03Z");

View file

@ -26,6 +26,7 @@ import static javax.servlet.http.HttpServletResponse.SC_INTERNAL_SERVER_ERROR;
import static javax.servlet.http.HttpServletResponse.SC_OK; import static javax.servlet.http.HttpServletResponse.SC_OK;
import static org.mockito.Matchers.any; import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyString; import static org.mockito.Matchers.anyString;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -41,11 +42,10 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link ExportReservedTermsAction}. */ /** Unit tests for {@link ExportReservedTermsAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class ExportReservedTermsActionTest { public class ExportReservedTermsActionTest {
@Rule @Rule
@ -53,11 +53,8 @@ public class ExportReservedTermsActionTest {
.withDatastore() .withDatastore()
.build(); .build();
@Mock private final DriveConnection driveConnection = mock(DriveConnection.class);
private DriveConnection driveConnection; private final Response response = mock(Response.class);
@Mock
private Response response;
private void runAction(String tld) { private void runAction(String tld) {
ExportReservedTermsAction action = new ExportReservedTermsAction(); ExportReservedTermsAction action = new ExportReservedTermsAction();

View file

@ -18,6 +18,7 @@ import static com.google.common.truth.Truth.assertThat;
import static google.registry.export.CheckSnapshotAction.CHECK_SNAPSHOT_KINDS_TO_LOAD_PARAM; import static google.registry.export.CheckSnapshotAction.CHECK_SNAPSHOT_KINDS_TO_LOAD_PARAM;
import static google.registry.export.CheckSnapshotAction.CHECK_SNAPSHOT_NAME_PARAM; import static google.registry.export.CheckSnapshotAction.CHECK_SNAPSHOT_NAME_PARAM;
import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued; import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import com.google.common.base.Joiner; import com.google.common.base.Joiner;
@ -30,16 +31,15 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link ExportSnapshotAction}. */ /** Unit tests for {@link ExportSnapshotAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class ExportSnapshotActionTest { public class ExportSnapshotActionTest {
@Rule public final AppEngineRule appEngine = AppEngineRule.builder().withTaskQueue().build(); @Rule public final AppEngineRule appEngine = AppEngineRule.builder().withTaskQueue().build();
@Mock private DatastoreBackupService backupService; private final DatastoreBackupService backupService = mock(DatastoreBackupService.class);
private final FakeResponse response = new FakeResponse(); private final FakeResponse response = new FakeResponse();
private final FakeClock clock = new FakeClock(DateTime.parse("2014-08-01T01:02:03Z")); private final FakeClock clock = new FakeClock(DateTime.parse("2014-08-01T01:02:03Z"));

View file

@ -26,6 +26,7 @@ import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued;
import static org.joda.time.DateTimeZone.UTC; import static org.joda.time.DateTimeZone.UTC;
import static org.mockito.Matchers.any; import static org.mockito.Matchers.any;
import static org.mockito.Matchers.eq; import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -54,12 +55,11 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
import org.mockito.ArgumentCaptor; import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link LoadSnapshotAction}. */ /** Unit tests for {@link LoadSnapshotAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class LoadSnapshotActionTest { public class LoadSnapshotActionTest {
@Rule @Rule
@ -70,26 +70,14 @@ public class LoadSnapshotActionTest {
@Rule @Rule
public final ExceptionRule thrown = new ExceptionRule(); public final ExceptionRule thrown = new ExceptionRule();
@Mock private final BigqueryFactory bigqueryFactory = mock(BigqueryFactory.class);
private BigqueryFactory bigqueryFactory; private final Bigquery bigquery = mock(Bigquery.class);
private final Bigquery.Jobs bigqueryJobs = mock(Bigquery.Jobs.class);
@Mock private final Bigquery.Jobs.Insert bigqueryJobsInsert = mock(Bigquery.Jobs.Insert.class);
private Bigquery bigquery; private final Bigquery.Datasets bigqueryDatasets = mock(Bigquery.Datasets.class);
private final Bigquery.Datasets.Insert bigqueryDatasetsInsert =
@Mock mock(Bigquery.Datasets.Insert.class);
private Bigquery.Jobs bigqueryJobs; private final BigqueryPollJobEnqueuer bigqueryPollEnqueuer = mock(BigqueryPollJobEnqueuer.class);
@Mock
private Bigquery.Jobs.Insert bigqueryJobsInsert;
@Mock
private Bigquery.Datasets bigqueryDatasets;
@Mock
private Bigquery.Datasets.Insert bigqueryDatasetsInsert;
@Mock
private BigqueryPollJobEnqueuer bigqueryPollEnqueuer;
private FakeClock clock = new FakeClock(new DateTime(1391096117045L, UTC)); private FakeClock clock = new FakeClock(new DateTime(1391096117045L, UTC));
private LoadSnapshotAction action; private LoadSnapshotAction action;

View file

@ -23,6 +23,7 @@ import static google.registry.testing.DatastoreHelper.persistResource;
import static java.nio.charset.StandardCharsets.UTF_8; import static java.nio.charset.StandardCharsets.UTF_8;
import static org.mockito.Matchers.any; import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyString; import static org.mockito.Matchers.anyString;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -46,11 +47,10 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link PublishDetailReportAction}. */ /** Unit tests for {@link PublishDetailReportAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class PublishDetailReportActionTest { public class PublishDetailReportActionTest {
@Rule @Rule
@ -61,8 +61,7 @@ public class PublishDetailReportActionTest {
.withDatastore() .withDatastore()
.build(); .build();
@Mock private final DriveConnection driveConnection = mock(DriveConnection.class);
private DriveConnection driveConnection;
private final PublishDetailReportAction action = new PublishDetailReportAction(); private final PublishDetailReportAction action = new PublishDetailReportAction();
private final GcsService gcsService = GcsServiceFactory.createGcsService(); private final GcsService gcsService = GcsServiceFactory.createGcsService();

View file

@ -26,6 +26,7 @@ import static javax.servlet.http.HttpServletResponse.SC_OK;
import static org.mockito.Matchers.any; import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyString; import static org.mockito.Matchers.anyString;
import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -48,8 +49,7 @@ import java.io.IOException;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** /**
* Unit tests for {@link SyncGroupMembersAction}. * Unit tests for {@link SyncGroupMembersAction}.
@ -57,7 +57,7 @@ import org.mockito.runners.MockitoJUnitRunner;
* <p>Note that this relies on the registrars NewRegistrar and TheRegistrar created by default in * <p>Note that this relies on the registrars NewRegistrar and TheRegistrar created by default in
* {@link AppEngineRule}. * {@link AppEngineRule}.
*/ */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class SyncGroupMembersActionTest { public class SyncGroupMembersActionTest {
@Rule @Rule
@ -71,11 +71,8 @@ public class SyncGroupMembersActionTest {
@Rule @Rule
public final InjectRule inject = new InjectRule(); public final InjectRule inject = new InjectRule();
@Mock private final DirectoryGroupsConnection connection = mock(DirectoryGroupsConnection.class);
private DirectoryGroupsConnection connection; private final Response response = mock(Response.class);
@Mock
private Response response;
private void runAction() { private void runAction() {
SyncGroupMembersAction action = new SyncGroupMembersAction(); SyncGroupMembersAction action = new SyncGroupMembersAction();

View file

@ -25,6 +25,7 @@ import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued;
import static org.mockito.Matchers.any; import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyString; import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.eq; import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -41,12 +42,11 @@ import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
import org.mockito.ArgumentCaptor; import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link UpdateSnapshotViewAction}. */ /** Unit tests for {@link UpdateSnapshotViewAction}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class UpdateSnapshotViewActionTest { public class UpdateSnapshotViewActionTest {
@Rule @Rule
@ -57,23 +57,13 @@ public class UpdateSnapshotViewActionTest {
@Rule @Rule
public final ExceptionRule thrown = new ExceptionRule(); public final ExceptionRule thrown = new ExceptionRule();
@Mock private final BigqueryFactory bigqueryFactory = mock(BigqueryFactory.class);
private BigqueryFactory bigqueryFactory; private final Bigquery bigquery = mock(Bigquery.class);
private final Bigquery.Datasets bigqueryDatasets = mock(Bigquery.Datasets.class);
@Mock private final Bigquery.Datasets.Insert bigqueryDatasetsInsert =
private Bigquery bigquery; mock(Bigquery.Datasets.Insert.class);
private final Bigquery.Tables bigqueryTables = mock(Bigquery.Tables.class);
@Mock private final Bigquery.Tables.Update bigqueryTablesUpdate = mock(Bigquery.Tables.Update.class);
private Bigquery.Datasets bigqueryDatasets;
@Mock
private Bigquery.Datasets.Insert bigqueryDatasetsInsert;
@Mock
private Bigquery.Tables bigqueryTables;
@Mock
private Bigquery.Tables.Update bigqueryTablesUpdate;
private UpdateSnapshotViewAction action; private UpdateSnapshotViewAction action;

View file

@ -26,10 +26,10 @@ import java.util.Map;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.runners.MockitoJUnitRunner; import org.junit.runners.JUnit4;
/** Unit tests for {@link CollectionUtils} */ /** Unit tests for {@link CollectionUtils} */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class CollectionUtilsTest { public class CollectionUtilsTest {
@Rule @Rule

View file

@ -16,21 +16,19 @@ package google.registry.util;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.fail; import static org.junit.Assert.fail;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.util.ArrayList; import java.util.ArrayList;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.junit.runners.JUnit4;
import org.mockito.runners.MockitoJUnitRunner;
/** Unit tests for {@link ComparingInvocationHandler}. */ /** Unit tests for {@link ComparingInvocationHandler}. */
@RunWith(MockitoJUnitRunner.class) @RunWith(JUnit4.class)
public class ComparingInvocationHandlerTest { public class ComparingInvocationHandlerTest {
static class Dummy { static class Dummy {
@ -106,8 +104,8 @@ public class ComparingInvocationHandlerTest {
private static final String ACTUAL_RESULT = "actual result"; private static final String ACTUAL_RESULT = "actual result";
private static final String SECOND_RESULT = "second result"; private static final String SECOND_RESULT = "second result";
@Mock MyInterface myActualMock; private final MyInterface myActualMock = mock(MyInterface.class);
@Mock MyInterface mySecondMock; private final MyInterface mySecondMock = mock(MyInterface.class);
private MyInterfaceComparingInvocationHandler invocationHandler; private MyInterfaceComparingInvocationHandler invocationHandler;
@Before public void setUp() { @Before public void setUp() {