zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-01 04:27:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add TODO to filter by tldState in billing pipeline

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=180973229
This commit is contained in:
larryruili 2018-01-05 14:10:25 -08:00 • committed by Ben McIlwain
parent 077600971f
commit d2d7fdeb90
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
java/google/registry/beam/sql/billing_events.sql
View file

@ -54,6 +54,7 @@ FROM (
FROM FROM
`%PROJECT_ID%.%DATASTORE_EXPORT_DATA_SET%.%REGISTRY_TABLE%` `%PROJECT_ID%.%DATASTORE_EXPORT_DATA_SET%.%REGISTRY_TABLE%`
WHERE WHERE
-- TODO(b/18092292): Add a filter for tldState (not PDT/PREDELEGATION)
tldType = 'REAL') ) AS BillingEvent tldType = 'REAL') ) AS BillingEvent
-- Gather billing ID from registrar table -- Gather billing ID from registrar table
-- This is a 'JOIN' as opposed to 'LEFT JOIN' to filter out -- This is a 'JOIN' as opposed to 'LEFT JOIN' to filter out

1
javatests/google/registry/beam/testdata/billing_events_test.sql vendored
View file

@ -54,6 +54,7 @@ FROM (
FROM FROM
`my-project-id.latest_datastore_export.Registry` `my-project-id.latest_datastore_export.Registry`
WHERE WHERE
-- TODO(b/18092292): Add a filter for tldState (not PDT/PREDELEGATION)
tldType = 'REAL') ) AS BillingEvent tldType = 'REAL') ) AS BillingEvent
-- Gather billing ID from registrar table -- Gather billing ID from registrar table
-- This is a 'JOIN' as opposed to 'LEFT JOIN' to filter out -- This is a 'JOIN' as opposed to 'LEFT JOIN' to filter out