From d285edef3d75ee71ec70a1344ce38f2923ec1034 Mon Sep 17 00:00:00 2001
From: Lai Jiang <jianglai@google.com>
Date: Tue, 4 May 2021 13:35:31 -0400
Subject: [PATCH] Fix a few linter warnings (#1122)

---
 .../registry/networking/handler/SslServerInitializer.java | 2 +-
 .../networking/handler/SslServerInitializerTest.java      | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/networking/src/main/java/google/registry/networking/handler/SslServerInitializer.java b/networking/src/main/java/google/registry/networking/handler/SslServerInitializer.java
index 08656eb83..638c40ef2 100644
--- a/networking/src/main/java/google/registry/networking/handler/SslServerInitializer.java
+++ b/networking/src/main/java/google/registry/networking/handler/SslServerInitializer.java
@@ -76,7 +76,7 @@ public class SslServerInitializer<C extends Channel> extends ChannelInitializer<
    * OpenSSL provider (if used), so there is no need to include the OpenSSL name variants here. More
    * information about these cipher suites and their OpenSSL names can be found at ciphersuite.info.
    */
-  private static final ImmutableList ALLOWED_TLS_CIPHERS =
+  private static final ImmutableList<String> ALLOWED_TLS_CIPHERS =
       ImmutableList.of(
           "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
           "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
diff --git a/networking/src/test/java/google/registry/networking/handler/SslServerInitializerTest.java b/networking/src/test/java/google/registry/networking/handler/SslServerInitializerTest.java
index 796671cc6..c73070876 100644
--- a/networking/src/test/java/google/registry/networking/handler/SslServerInitializerTest.java
+++ b/networking/src/test/java/google/registry/networking/handler/SslServerInitializerTest.java
@@ -458,8 +458,12 @@ class SslServerInitializerTest {
   private static boolean compareSemanticVersion(
       ImmutableList<Integer> v1, ImmutableList<Integer> v2) {
     for (int i : ImmutableList.of(0, 1, 2)) {
-      if (v1.get(i) > v2.get(i)) return true;
-      if (v1.get(i) < v2.get(i)) return false;
+      if (v1.get(i) > v2.get(i)) {
+        return true;
+      }
+      if (v1.get(i) < v2.get(i)) {
+        return false;
+      }
     }
     return true;
   }