zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 08:57:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use compound return statements for greater readability

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=173451653
This commit is contained in:
mcilwain 2017-10-25 14:39:36 -07:00 • committed by jianglai
parent eed2e0c45f
commit d22986a0a3
3 changed files with 4 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

5
java/google/registry/gcs/GcsUtils.java
View file

@ -81,10 +81,7 @@ public class GcsUtils {
logger.warning(e, "Failed to check if GCS file exists");
return false;
}
if (metadata == null) {
return false;
}
return metadata.getLength() > 0;
return metadata != null && metadata.getLength() > 0;
}
/** Determines most appropriate {@link GcsFileOptions} based on filename extension. */

5
java/google/registry/model/smd/SignedMarkRevocationList.java
View file

@ -140,10 +140,7 @@ public class SignedMarkRevocationList extends ImmutableObject {
/** Returns {@code true} if the SMD ID has been revoked at the given point in time. */
public boolean isSmdRevoked(String smdId, DateTime now) {
DateTime revoked = revokes.get(checkNotNull(smdId, "smdId"));
if (revoked == null) {
return false;
}
return isBeforeOrAt(revoked, now);
return revoked != null && isBeforeOrAt(revoked, now);
}
/** Returns the creation timestamp specified at the top of the SMDRL CSV file. */

10
javatests/google/registry/dns/writer/clouddns/CloudDnsWriterTest.java
View file

@ -130,14 +130,8 @@ public class CloudDnsWriterTest {
stubZone
.stream()
.filter(
resourceRecordSet -> {
if (resourceRecordSet == null) {
return false;
}
return resourceRecordSet
.getName()
.equals(recordNameCaptor.getValue());
})
rs ->
rs != null && rs.getName().equals(recordNameCaptor.getValue()))
.collect(toImmutableList()));
}
});