Use an enum instead of boolean in EntityTestCase constructor (#669)

* Use an enum instead of boolean in EntityTestCase constructor

It's more clear to use an enum rather than just a simple boolean

* Add Javadoc and make the enum name more verbose

core/src/test/java/google/registry/model/EntityTestCase.java

@@ -49,6 +49,16 @@ import org.junit.jupiter.api.extension.RegisterExtension;
 /** Base class of all unit tests for entities which are persisted to Datastore via Objectify. */
 public abstract class EntityTestCase {
 
+  protected enum JpaEntityCoverageCheck {
+    /**
+     * The test will contribute to the coverage checks in {@link
+     * google.registry.schema.integration.SqlIntegrationTestSuite}.
+     */
+    ENABLED,
+    /** The test is not relevant for JPA coverage checks. */
+    DISABLED;
+  }
+
   protected FakeClock fakeClock = new FakeClock(DateTime.now(UTC));
 
   @Rule @RegisterExtension public final AppEngineRule appEngine;
@@ -56,14 +66,14 @@ public abstract class EntityTestCase {
   @Rule @RegisterExtension public InjectRule inject = new InjectRule();
 
   protected EntityTestCase() {
-    this(false);
+    this(JpaEntityCoverageCheck.DISABLED);
   }
 
-  protected EntityTestCase(boolean enableJpaEntityCheck) {
+  protected EntityTestCase(JpaEntityCoverageCheck jpaEntityCoverageCheck) {
     appEngine =
         AppEngineRule.builder()
             .withDatastoreAndCloudSql()
-            .enableJpaEntityCoverageCheck(enableJpaEntityCheck)
+            .enableJpaEntityCoverageCheck(jpaEntityCoverageCheck == JpaEntityCoverageCheck.ENABLED)
             .withClock(fakeClock)
             .build();
   }

core/src/test/java/google/registry/model/billing/BillingEventTest.java

@@ -51,7 +51,7 @@ public class BillingEventTest extends EntityTestCase {
   private final DateTime now = DateTime.now(UTC);
 
   public BillingEventTest() {
-    super(true);
+    super(JpaEntityCoverageCheck.ENABLED);
   }
 
   HistoryEntry historyEntry;

core/src/test/java/google/registry/model/contact/ContactResourceTest.java

@@ -49,7 +49,7 @@ public class ContactResourceTest extends EntityTestCase {
   ContactResource contactResource;
 
   public ContactResourceTest() {
-    super(true);
+    super(JpaEntityCoverageCheck.ENABLED);
   }
 
   @BeforeEach

core/src/test/java/google/registry/model/history/ContactHistoryTest.java

@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
 public class ContactHistoryTest extends EntityTestCase {
 
   public ContactHistoryTest() {
-    super(true);
+    super(JpaEntityCoverageCheck.ENABLED);
   }
 
   @Test

core/src/test/java/google/registry/model/history/HostHistoryTest.java

@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
 public class HostHistoryTest extends EntityTestCase {
 
   public HostHistoryTest() {
-    super(true);
+    super(JpaEntityCoverageCheck.ENABLED);
   }
 
   @Test

core/src/test/java/google/registry/model/poll/PollMessageTest.java

@@ -39,7 +39,7 @@ public class PollMessageTest extends EntityTestCase {
   PollMessage.Autorenew autoRenew;
 
   public PollMessageTest() {
-    super(true);
+    super(JpaEntityCoverageCheck.ENABLED);
   }
 
   @BeforeEach

core/src/test/java/google/registry/model/registry/RegistryLockDaoTest.java

@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
 public final class RegistryLockDaoTest extends EntityTestCase {
 
   public RegistryLockDaoTest() {
-    super(true);
+    super(JpaEntityCoverageCheck.ENABLED);
   }
 
   @Test

core/src/test/java/google/registry/model/reporting/Spec11ThreatMatchTest.java

@@ -47,7 +47,7 @@ public class Spec11ThreatMatchTest extends EntityTestCase {
   private ContactResource registrantContact;
 
   public Spec11ThreatMatchTest() {
-    super(true);
+    super(JpaEntityCoverageCheck.ENABLED);
   }
 
   @BeforeEach