zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-04-30 12:07:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use google.registry namespace for specifying RegistryConfig impl

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135386524
This commit is contained in:
mcilwain 2016-10-06 11:55:02 -07:00 • committed by Ben McIlwain
parent 0ae5d10632
commit d02d30a4cd
2 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
docs/configuration.md
View file

@ -54,13 +54,17 @@ If you are adding new options, prefer adding them to `ConfigModule`.
**`RegistryConfig`** is an interface, of which you write an implementing class **`RegistryConfig`** is an interface, of which you write an implementing class
containing the configuration values. `RegistryConfigLoader` is the class that containing the configuration values. `RegistryConfigLoader` is the class that
provides the instance of `RegistryConfig`, and defaults to returning provides the instance of `RegistryConfig`, and defaults to returning
`ProductionRegistryConfigExample`. In order to create a configuration specific `ProductionRegistryConfigExample`.
to your registry, we recommend copying the `ProductionRegistryConfigExample`
class to a new class that will not be shared publicly, setting the In order to create a configuration specific to your registry, we recommend
`com.google.domain.registry.config` system property in `appengine-web.xml` to copying the `ProductionRegistryConfigExample` class to a new class that will not
the fully qualified class name of that new class so that `RegistryConfigLoader` be shared publicly, setting the `google.registry.config` system property in the
will load it instead, and then editing said new class to add your specific `appengine-web.xml` files to the fully qualified class name of that new class
configuration options. so that `RegistryConfigLoader` will load it instead, and then editing said new
class to add your specific configuration options. There is one
`appengine-web.xml` file per service (so three per environment). The same
configuration class must be used for each service, but different ones can be
used for different environments.
The `RegistryConfig` class has documentation on all of the methods that should The `RegistryConfig` class has documentation on all of the methods that should
be sufficient to explain what each option is, and be sufficient to explain what each option is, and

2
java/google/registry/config/RegistryConfigLoader.java
View file

@ -30,7 +30,7 @@ import javax.annotation.concurrent.ThreadSafe;
@ThreadSafe @ThreadSafe
public final class RegistryConfigLoader { public final class RegistryConfigLoader {
public static final String REGISTRY_CONFIG_PROPERTY = "com.google.domain.registry.config"; public static final String REGISTRY_CONFIG_PROPERTY = "google.registry.config";
public static final String REGISTRY_CONFIG_DEFAULT = public static final String REGISTRY_CONFIG_DEFAULT =
"google.registry.config.ProductionRegistryConfigExample"; "google.registry.config.ProductionRegistryConfigExample";