mirror of
https://github.com/google/nomulus.git
synced 2025-07-03 01:33:29 +02:00
Upgrade to Beam 2.34.0 (#1472)
This version of Beam does not have an explicit dependency on log4j. There are a couple of other things that need to change due to the upgrade. 1) The new version pulls in a dependency that is not on Maven Central but on packages.confluent.io, so we need to explicitly add this repo. 2) The new version has a dependency on flogger 0.6 anb above , which removed the LoggerConfig class (see google/flogger#142). We therefore backported the class. In the long term we should do what was suggested in the issue and use the normal JDK Logger config directly. 3) The intSqlPipeline dependency graph also needs to be updated. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/google/nomulus/1472) <!-- Reviewable:end -->
This commit is contained in:
parent
bde9041600
commit
ce65b69e2e
135 changed files with 8778 additions and 7605 deletions
|
@ -28,7 +28,6 @@ import com.google.cloud.storage.BlobId;
|
|||
import com.google.cloud.storage.Storage;
|
||||
import com.google.cloud.storage.StorageException;
|
||||
import com.google.cloud.storage.StorageOptions;
|
||||
import com.google.common.flogger.LoggerConfig;
|
||||
import com.google.monitoring.metrics.MetricReporter;
|
||||
import dagger.Component;
|
||||
import dagger.Module;
|
||||
|
@ -45,6 +44,7 @@ import google.registry.proxy.WhoisProtocolModule.WhoisProtocol;
|
|||
import google.registry.proxy.handler.ProxyProtocolHandler;
|
||||
import google.registry.util.Clock;
|
||||
import google.registry.util.GoogleCredentialsBundle;
|
||||
import google.registry.util.JdkLoggerConfig;
|
||||
import google.registry.util.SystemClock;
|
||||
import io.netty.handler.logging.LogLevel;
|
||||
import io.netty.handler.logging.LoggingHandler;
|
||||
|
@ -110,7 +110,7 @@ public class ProxyModule {
|
|||
*/
|
||||
private void configureLogging() {
|
||||
// Remove all other handlers on the root logger to avoid double logging.
|
||||
LoggerConfig rootLoggerConfig = LoggerConfig.getConfig("");
|
||||
JdkLoggerConfig rootLoggerConfig = JdkLoggerConfig.getConfig("");
|
||||
Arrays.asList(rootLoggerConfig.getHandlers()).forEach(rootLoggerConfig::removeHandler);
|
||||
|
||||
// If running on in a non-local environment, use GCP JSON formatter.
|
||||
|
@ -128,10 +128,10 @@ public class ProxyModule {
|
|||
// set to Level.FINE if the --log parameter is passed, so that it does not filter out logs
|
||||
// that the LoggingHandler writes. Otherwise the logs are silently ignored because the default
|
||||
// JUL logger level is Level.INFO.
|
||||
LoggerConfig.getConfig(LoggingHandler.class).setLevel(Level.FINE);
|
||||
JdkLoggerConfig.getConfig(LoggingHandler.class).setLevel(Level.FINE);
|
||||
// Log source IP information if --log parameter is passed. This is considered PII and should
|
||||
// only be used in non-production environment for debugging purpose.
|
||||
LoggerConfig.getConfig(ProxyProtocolHandler.class).setLevel(Level.FINE);
|
||||
JdkLoggerConfig.getConfig(ProxyProtocolHandler.class).setLevel(Level.FINE);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue