zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-23 19:20:44 +02:00
Code Issues Projects Releases Packages Wiki Activity

Filter in SQL when updating/deleting alloc tokens (#2244)

Browse source 
This doesn't fix any issues with dead/livelocks when deleting or
updating allocation tokens, but it at least will significantly reduce
the time to load the tokens that we'll want to update/delete.
This commit is contained in:
gbrodman 2023-12-04 19:24:17 -05:00 • committed by GitHub
parent dd86c56ddc
commit cc9b3f5965
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
core/src/main/java/google/registry/tools/UpdateOrDeleteAllocationTokensCommand.java
View file

@ -67,9 +67,12 @@ abstract class UpdateOrDeleteAllocationTokensCommand extends ConfirmingCommand {
checkArgument(!prefix.isEmpty(), "Provided prefix should not be blank"); checkArgument(!prefix.isEmpty(), "Provided prefix should not be blank");
return tm().transact( return tm().transact(
() -> () ->
tm().loadAllOf(AllocationToken.class).stream() tm().query(
.filter(token -> token.getToken().startsWith(prefix)) "SELECT token FROM AllocationToken WHERE token LIKE :prefix",
.map(AllocationToken::createVKey) String.class)
.setParameter("prefix", String.format("%s%%", prefix))
.getResultStream()
.map(token -> VKey.create(AllocationToken.class, token))
.collect(toImmutableList())); .collect(toImmutableList()));
} }
} }