zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-09 04:33:28 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add logging to CursorDao.saveCursor (#486)

Browse source 
* Add log messages

* small fix

* add null check

* change to checkArgumentNotNull
This commit is contained in:
sarahcaseybot 2020-02-21 15:49:45 -05:00 • committed by GitHub
parent 1be0ad885c
commit cbe216ced2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

21
core/src/test/java/google/registry/schema/cursor/CursorDaoTest.java
View file

@ -190,27 +190,6 @@ public class CursorDaoTest {
assertThat(cursor).isEqualTo(dataStoreCursor);
}
@Test
public void saveCursor_logsErrorWhenSaveToCloudSqlFails() {
loggerToIntercept.addHandler(logHandler);
createTld("tld");
google.registry.model.common.Cursor cursor =
google.registry.model.common.Cursor.create(
CursorType.ICANN_UPLOAD_ACTIVITY, fakeClock.nowUtc(), Registry.get("tld"));
CursorDao.saveCursor(cursor, null);
assertAboutLogs()
.that(logHandler)
.hasLogAtLevelWithMessage(Level.SEVERE, "Error saving cursor to Cloud SQL.");
google.registry.model.common.Cursor dataStoreCursor =
ofy()
.load()
.key(
google.registry.model.common.Cursor.createKey(
CursorType.ICANN_UPLOAD_ACTIVITY, Registry.get("tld")))
.now();
assertThat(cursor).isEqualTo(dataStoreCursor);
}
@Test
public void saveCursors_worksSuccessfully() {
createTlds("tld", "foo");