zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 17:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Wait for contact add page to load before doing screenshot diff (#756)

Browse source 
This test is flaky and the going theory is that we take a screenshot
immediately after we click the "Add" button and the CSS hover effect is
somehow still playing on the button.
This commit is contained in:
Lai Jiang 2020-08-10 13:29:47 -04:00 • committed by GitHub
parent 05ddabd003
commit cbdf41d75a
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
core/src/test/java/google/registry/webdriver/RegistrarConsoleScreenshotTest.java
View file

@ -238,6 +238,9 @@ class RegistrarConsoleScreenshotTest extends WebDriverTestCase {
Thread.sleep(1000); Thread.sleep(1000);
driver.waitForElement(By.tagName("h1")); driver.waitForElement(By.tagName("h1"));
driver.waitForElement(By.id("reg-app-btn-add")).click(); driver.waitForElement(By.id("reg-app-btn-add")).click();
// Attempt to fix flaky tests. The going theory is that the click button CSS animation needs to
// finish before the screenshot is captured.
Thread.sleep(250);
driver.diffPage("page"); driver.diffPage("page");
} }