mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 04:27:51 +02:00
Add an explanation to dummied-out JPA init (#299)
* Add an explanation to dummied-out JPA init Add a more elaborate explanation of why actual JpaTransactionManager initialization was removed from the factory.
This commit is contained in:
parent
0855040bd7
commit
cb78fba52c
1 changed files with 6 additions and 0 deletions
|
@ -33,6 +33,12 @@ public class TransactionManagerFactory {
|
||||||
// PostgreSQL tables in production, ensure that all of the test environments are set up
|
// PostgreSQL tables in production, ensure that all of the test environments are set up
|
||||||
// correctly and restore the code that creates a JpaTransactionManager when
|
// correctly and restore the code that creates a JpaTransactionManager when
|
||||||
// RegistryEnvironment.get() != UNITTEST.
|
// RegistryEnvironment.get() != UNITTEST.
|
||||||
|
//
|
||||||
|
// We removed the original code because it didn't work in sandbox (due to the absence of the
|
||||||
|
// persistence.xml file, which has since been added), and then (after adding this) didn't work
|
||||||
|
// in crash because the postgresql password hadn't been set up. Prior to restoring, we'll need
|
||||||
|
// to do setup in all environments, and we probably only want to do this once we're actually
|
||||||
|
// using Cloud SQL for one of the new tables.
|
||||||
return DummyJpaTransactionManager.create();
|
return DummyJpaTransactionManager.create();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Add table
Reference in a new issue