From cb240a8f03a152b20bc36de41c032e978b854802 Mon Sep 17 00:00:00 2001 From: Lai Jiang Date: Thu, 28 Sep 2023 13:27:36 -0400 Subject: [PATCH] Use equals() method to compare equality (#2158) It will call equalsImmutableObject(), which seems the right thing to do. We only care if the two Tld objects have the same fields, not if they are the same object. ErrorProne complained about comparison by identity. --- core/src/main/java/google/registry/model/tld/Tld.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/google/registry/model/tld/Tld.java b/core/src/main/java/google/registry/model/tld/Tld.java index 2ccc6c275..e2b5cadcf 100644 --- a/core/src/main/java/google/registry/model/tld/Tld.java +++ b/core/src/main/java/google/registry/model/tld/Tld.java @@ -130,7 +130,7 @@ public class Tld extends ImmutableObject implements Buildable, UnsafeSerializabl public static final Money DEFAULT_REGISTRY_LOCK_OR_UNLOCK_BILLING_COST = Money.of(USD, 0); public boolean equalYaml(Tld tldToCompare) { - if (this == tldToCompare) { + if (this.equals(tldToCompare)) { return true; } ObjectMapper mapper = createObjectMapper();