mirror of
https://github.com/google/nomulus.git
synced 2025-07-22 18:55:58 +02:00
Remove some unnecessary uses of MockitoJUnitRunner, which is discouraged
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=154202151
This commit is contained in:
parent
51cfc12c1d
commit
cb145e0721
6 changed files with 21 additions and 6 deletions
|
@ -11,6 +11,7 @@ java_library(
|
||||||
name = "clouddns",
|
name = "clouddns",
|
||||||
srcs = glob(["*Test.java"]),
|
srcs = glob(["*Test.java"]),
|
||||||
deps = [
|
deps = [
|
||||||
|
"//java/com/google/testing/mockito",
|
||||||
"//java/google/registry/dns/writer/clouddns",
|
"//java/google/registry/dns/writer/clouddns",
|
||||||
"//java/google/registry/model",
|
"//java/google/registry/model",
|
||||||
"//java/google/registry/util",
|
"//java/google/registry/util",
|
||||||
|
|
|
@ -38,6 +38,7 @@ import com.google.common.collect.ImmutableSet;
|
||||||
import com.google.common.collect.Sets;
|
import com.google.common.collect.Sets;
|
||||||
import com.google.common.net.InetAddresses;
|
import com.google.common.net.InetAddresses;
|
||||||
import com.google.common.util.concurrent.RateLimiter;
|
import com.google.common.util.concurrent.RateLimiter;
|
||||||
|
import com.google.testing.mockito.Mocks;
|
||||||
import com.googlecode.objectify.Key;
|
import com.googlecode.objectify.Key;
|
||||||
import google.registry.dns.writer.clouddns.CloudDnsWriter.ZoneStateException;
|
import google.registry.dns.writer.clouddns.CloudDnsWriter.ZoneStateException;
|
||||||
import google.registry.model.domain.DomainResource;
|
import google.registry.model.domain.DomainResource;
|
||||||
|
@ -60,18 +61,21 @@ import org.junit.Before;
|
||||||
import org.junit.Rule;
|
import org.junit.Rule;
|
||||||
import org.junit.Test;
|
import org.junit.Test;
|
||||||
import org.junit.runner.RunWith;
|
import org.junit.runner.RunWith;
|
||||||
|
import org.junit.runners.JUnit4;
|
||||||
import org.mockito.ArgumentCaptor;
|
import org.mockito.ArgumentCaptor;
|
||||||
import org.mockito.Captor;
|
import org.mockito.Captor;
|
||||||
import org.mockito.Matchers;
|
import org.mockito.Matchers;
|
||||||
import org.mockito.Mock;
|
import org.mockito.Mock;
|
||||||
import org.mockito.invocation.InvocationOnMock;
|
import org.mockito.invocation.InvocationOnMock;
|
||||||
import org.mockito.runners.MockitoJUnitRunner;
|
|
||||||
import org.mockito.stubbing.Answer;
|
import org.mockito.stubbing.Answer;
|
||||||
|
|
||||||
/** Test case for {@link CloudDnsWriter}. */
|
/** Test case for {@link CloudDnsWriter}. */
|
||||||
@RunWith(MockitoJUnitRunner.class)
|
@RunWith(JUnit4.class)
|
||||||
public class CloudDnsWriterTest {
|
public class CloudDnsWriterTest {
|
||||||
|
|
||||||
|
@Rule
|
||||||
|
public final Mocks mocks = new Mocks(this);
|
||||||
|
|
||||||
private static final Inet4Address IPv4 = (Inet4Address) InetAddresses.forString("127.0.0.1");
|
private static final Inet4Address IPv4 = (Inet4Address) InetAddresses.forString("127.0.0.1");
|
||||||
private static final Inet6Address IPv6 = (Inet6Address) InetAddresses.forString("::1");
|
private static final Inet6Address IPv6 = (Inet6Address) InetAddresses.forString("::1");
|
||||||
private static final DelegationSignerData DS_DATA =
|
private static final DelegationSignerData DS_DATA =
|
||||||
|
|
|
@ -11,6 +11,7 @@ java_library(
|
||||||
name = "dnsupdate",
|
name = "dnsupdate",
|
||||||
srcs = glob(["*.java"]),
|
srcs = glob(["*.java"]),
|
||||||
deps = [
|
deps = [
|
||||||
|
"//java/com/google/testing/mockito",
|
||||||
"//java/google/registry/dns/writer/dnsupdate",
|
"//java/google/registry/dns/writer/dnsupdate",
|
||||||
"//java/google/registry/model",
|
"//java/google/registry/model",
|
||||||
"//javatests/google/registry/testing",
|
"//javatests/google/registry/testing",
|
||||||
|
|
|
@ -34,6 +34,7 @@ import com.google.common.base.VerifyException;
|
||||||
import com.google.common.collect.ImmutableList;
|
import com.google.common.collect.ImmutableList;
|
||||||
import com.google.common.collect.ImmutableSet;
|
import com.google.common.collect.ImmutableSet;
|
||||||
import com.google.common.net.InetAddresses;
|
import com.google.common.net.InetAddresses;
|
||||||
|
import com.google.testing.mockito.Mocks;
|
||||||
import com.googlecode.objectify.Key;
|
import com.googlecode.objectify.Key;
|
||||||
import google.registry.model.domain.DomainResource;
|
import google.registry.model.domain.DomainResource;
|
||||||
import google.registry.model.domain.secdns.DelegationSignerData;
|
import google.registry.model.domain.secdns.DelegationSignerData;
|
||||||
|
@ -52,10 +53,10 @@ import org.junit.Before;
|
||||||
import org.junit.Rule;
|
import org.junit.Rule;
|
||||||
import org.junit.Test;
|
import org.junit.Test;
|
||||||
import org.junit.runner.RunWith;
|
import org.junit.runner.RunWith;
|
||||||
|
import org.junit.runners.JUnit4;
|
||||||
import org.mockito.ArgumentCaptor;
|
import org.mockito.ArgumentCaptor;
|
||||||
import org.mockito.Captor;
|
import org.mockito.Captor;
|
||||||
import org.mockito.Mock;
|
import org.mockito.Mock;
|
||||||
import org.mockito.runners.MockitoJUnitRunner;
|
|
||||||
import org.xbill.DNS.Flags;
|
import org.xbill.DNS.Flags;
|
||||||
import org.xbill.DNS.Message;
|
import org.xbill.DNS.Message;
|
||||||
import org.xbill.DNS.Opcode;
|
import org.xbill.DNS.Opcode;
|
||||||
|
@ -67,7 +68,7 @@ import org.xbill.DNS.Type;
|
||||||
import org.xbill.DNS.Update;
|
import org.xbill.DNS.Update;
|
||||||
|
|
||||||
/** Unit tests for {@link DnsUpdateWriter}. */
|
/** Unit tests for {@link DnsUpdateWriter}. */
|
||||||
@RunWith(MockitoJUnitRunner.class)
|
@RunWith(JUnit4.class)
|
||||||
public class DnsUpdateWriterTest {
|
public class DnsUpdateWriterTest {
|
||||||
|
|
||||||
@Rule
|
@Rule
|
||||||
|
@ -80,6 +81,9 @@ public class DnsUpdateWriterTest {
|
||||||
@Rule
|
@Rule
|
||||||
public final InjectRule inject = new InjectRule();
|
public final InjectRule inject = new InjectRule();
|
||||||
|
|
||||||
|
@Rule
|
||||||
|
public final Mocks mocks = new Mocks(this);
|
||||||
|
|
||||||
@Mock
|
@Mock
|
||||||
private DnsMessageTransport mockResolver;
|
private DnsMessageTransport mockResolver;
|
||||||
|
|
||||||
|
|
|
@ -9,6 +9,7 @@ java_library(
|
||||||
name = "sheet",
|
name = "sheet",
|
||||||
srcs = glob(["*.java"]),
|
srcs = glob(["*.java"]),
|
||||||
deps = [
|
deps = [
|
||||||
|
"//java/com/google/testing/mockito",
|
||||||
"//java/google/registry/config",
|
"//java/google/registry/config",
|
||||||
"//java/google/registry/export/sheet",
|
"//java/google/registry/export/sheet",
|
||||||
"//java/google/registry/model",
|
"//java/google/registry/model",
|
||||||
|
|
|
@ -32,6 +32,7 @@ import static org.mockito.Mockito.verify;
|
||||||
import com.google.common.collect.ImmutableList;
|
import com.google.common.collect.ImmutableList;
|
||||||
import com.google.common.collect.ImmutableMap;
|
import com.google.common.collect.ImmutableMap;
|
||||||
import com.google.common.collect.ImmutableSet;
|
import com.google.common.collect.ImmutableSet;
|
||||||
|
import com.google.testing.mockito.Mocks;
|
||||||
import google.registry.model.common.Cursor;
|
import google.registry.model.common.Cursor;
|
||||||
import google.registry.model.ofy.Ofy;
|
import google.registry.model.ofy.Ofy;
|
||||||
import google.registry.model.registrar.Registrar;
|
import google.registry.model.registrar.Registrar;
|
||||||
|
@ -45,13 +46,13 @@ import org.junit.Before;
|
||||||
import org.junit.Rule;
|
import org.junit.Rule;
|
||||||
import org.junit.Test;
|
import org.junit.Test;
|
||||||
import org.junit.runner.RunWith;
|
import org.junit.runner.RunWith;
|
||||||
|
import org.junit.runners.JUnit4;
|
||||||
import org.mockito.ArgumentCaptor;
|
import org.mockito.ArgumentCaptor;
|
||||||
import org.mockito.Captor;
|
import org.mockito.Captor;
|
||||||
import org.mockito.Mock;
|
import org.mockito.Mock;
|
||||||
import org.mockito.runners.MockitoJUnitRunner;
|
|
||||||
|
|
||||||
/** Unit tests for {@link SyncRegistrarsSheet}. */
|
/** Unit tests for {@link SyncRegistrarsSheet}. */
|
||||||
@RunWith(MockitoJUnitRunner.class)
|
@RunWith(JUnit4.class)
|
||||||
public class SyncRegistrarsSheetTest {
|
public class SyncRegistrarsSheetTest {
|
||||||
|
|
||||||
@Rule
|
@Rule
|
||||||
|
@ -62,6 +63,9 @@ public class SyncRegistrarsSheetTest {
|
||||||
@Rule
|
@Rule
|
||||||
public final InjectRule inject = new InjectRule();
|
public final InjectRule inject = new InjectRule();
|
||||||
|
|
||||||
|
@Rule
|
||||||
|
public final Mocks mocks = new Mocks(this);
|
||||||
|
|
||||||
@Captor
|
@Captor
|
||||||
private ArgumentCaptor<ImmutableList<ImmutableMap<String, String>>> rowsCaptor;
|
private ArgumentCaptor<ImmutableList<ImmutableMap<String, String>>> rowsCaptor;
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue