Add replay to remaining (non-trivial) flow tests (#1020)

* Add replay to remaining (non-trivial) flow tests

Convert all remaining flow tests to do replay/compare testing.  In the course
of this:
- Move the class specific SetClock extension into its own place.
- Fix another "cyclic" foreign key (there may be another solution in this case
  because HostHistory is actually different from HistoryEntry, but that would
  require changing the way we establish priority since HostHistory is not
  distinguished from HistoryEntry in the current methodology)
This commit is contained in:
Michael Muller 2021-03-19 13:20:53 -04:00 committed by GitHub
parent 5befc142f5
commit c827ea033a
18 changed files with 178 additions and 75 deletions

View file

@ -261,11 +261,11 @@ td.section {
</tr>
<tr>
<td class="property_name">generated on</td>
<td class="property_value">2021-03-18 19:08:16.381352</td>
<td class="property_value">2021-03-19 12:31:33.396532</td>
</tr>
<tr>
<td class="property_name">last flyway file</td>
<td id="lastFlywayFile" class="property_value">V88__transfer_billing_cancellation_history_id.sql</td>
<td id="lastFlywayFile" class="property_value">V89__host_history_host_deferred.sql</td>
</tr>
</tbody>
</table>
@ -284,7 +284,7 @@ td.section {
generated on
</text>
<text text-anchor="start" x="4027.94" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">
2021-03-18 19:08:16.381352
2021-03-19 12:31:33.396532
</text>
<polygon fill="none" stroke="#888888" points="3940.44,-4 3940.44,-44 4205.44,-44 4205.44,-4 3940.44,-4" /> <!-- allocationtoken_a08ccbef -->
<g id="node1" class="node">
@ -2484,8 +2484,8 @@ td.section {
<polyline fill="none" stroke="black" points="191.5,-646.68 195.4,-643.55 " />
<polygon fill="black" stroke="black" points="199.31,-646.82 193.05,-639.02 194.61,-637.77 200.87,-645.57 199.31,-646.82" />
<polyline fill="none" stroke="black" points="195.4,-643.55 199.3,-640.42 " />
<text text-anchor="start" x="1178.5" y="-280.48" font-family="Helvetica,sans-Serif" font-size="14.00">
fk3d09knnmxrt6iniwnp8j2ykga
<text text-anchor="start" x="1203" y="-280.48" font-family="Helvetica,sans-Serif" font-size="14.00">
fk_history_registrar_id
</text>
</g> <!-- kmssecret_f3b28857 -->
<g id="node22" class="node">
@ -5357,7 +5357,7 @@ td.section {
<td colspan="3"></td>
</tr>
<tr>
<td colspan="2" class="name">fk3d09knnmxrt6iniwnp8j2ykga</td>
<td colspan="2" class="name">fk_history_registrar_id</td>
<td class="description right">[foreign key, with no action]</td>
</tr>
<tr>
@ -6110,7 +6110,7 @@ td.section {
<td colspan="3"></td>
</tr>
<tr>
<td colspan="2" class="name">fk3d09knnmxrt6iniwnp8j2ykga</td>
<td colspan="2" class="name">fk_history_registrar_id</td>
<td class="description right">[foreign key, with no action]</td>
</tr>
<tr>

View file

@ -261,11 +261,11 @@ td.section {
</tr>
<tr>
<td class="property_name">generated on</td>
<td class="property_value">2021-03-18 19:08:14.574191</td>
<td class="property_value">2021-03-19 12:31:31.233378</td>
</tr>
<tr>
<td class="property_name">last flyway file</td>
<td id="lastFlywayFile" class="property_value">V88__transfer_billing_cancellation_history_id.sql</td>
<td id="lastFlywayFile" class="property_value">V89__host_history_host_deferred.sql</td>
</tr>
</tbody>
</table>
@ -284,7 +284,7 @@ td.section {
generated on
</text>
<text text-anchor="start" x="4626.68" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">
2021-03-18 19:08:14.574191
2021-03-19 12:31:31.233378
</text>
<polygon fill="none" stroke="#888888" points="4539.18,-4 4539.18,-44 4804.18,-44 4804.18,-4 4539.18,-4" /> <!-- allocationtoken_a08ccbef -->
<g id="node1" class="node">
@ -5580,8 +5580,8 @@ td.section {
<polyline fill="none" stroke="black" points="298,-1144.89 302.29,-1142.32 " />
<polygon fill="black" stroke="black" points="305.72,-1146.1 300.58,-1137.52 302.3,-1136.49 307.43,-1145.08 305.72,-1146.1" />
<polyline fill="none" stroke="black" points="302.29,-1142.32 306.58,-1139.76 " />
<text text-anchor="start" x="1422" y="-485.69" font-family="Helvetica,sans-Serif" font-size="14.00">
fk3d09knnmxrt6iniwnp8j2ykga
<text text-anchor="start" x="1446.5" y="-485.69" font-family="Helvetica,sans-Serif" font-size="14.00">
fk_history_registrar_id
</text>
</g> <!-- kmssecret_f3b28857 -->
<g id="node22" class="node">
@ -11079,7 +11079,7 @@ td.section {
<td colspan="3"></td>
</tr>
<tr>
<td colspan="2" class="name">fk3d09knnmxrt6iniwnp8j2ykga</td>
<td colspan="2" class="name">fk_history_registrar_id</td>
<td class="description right">[foreign key, with no action]</td>
</tr>
<tr>
@ -12436,7 +12436,7 @@ td.section {
<td colspan="3"></td>
</tr>
<tr>
<td colspan="2" class="name">fk3d09knnmxrt6iniwnp8j2ykga</td>
<td colspan="2" class="name">fk_history_registrar_id</td>
<td class="description right">[foreign key, with no action]</td>
</tr>
<tr>

View file

@ -86,3 +86,4 @@ V85__add_required_columns_in_transfer_data.sql
V86__third_poll_message.sql
V87__fix_super_domain_fk.sql
V88__transfer_billing_cancellation_history_id.sql
V89__host_history_host_deferred.sql

View file

@ -0,0 +1,25 @@
-- Copyright 2021 The Nomulus Authors. All Rights Reserved.
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.
ALTER TABLE "HostHistory" DROP CONSTRAINT fk3d09knnmxrt6iniwnp8j2ykga;
ALTER TABLE "HostHistory" DROP CONSTRAINT fk_hosthistory_host;
ALTER TABLE "HostHistory" ADD CONSTRAINT fk_history_registrar_id
FOREIGN KEY (history_registrar_id)
REFERENCES "Registrar"(registrar_id)
DEFERRABLE INITIALLY DEFERRED;
ALTER TABLE "HostHistory" ADD CONSTRAINT fk_hosthistory_host
FOREIGN KEY (host_repo_id)
REFERENCES "Host"(repo_id)
DEFERRABLE INITIALLY DEFERRED;

View file

@ -1867,14 +1867,6 @@ ALTER TABLE ONLY public."Domain"
ADD CONSTRAINT fk2u3srsfbei272093m3b3xwj23 FOREIGN KEY (current_sponsor_registrar_id) REFERENCES public."Registrar"(registrar_id);
--
-- Name: HostHistory fk3d09knnmxrt6iniwnp8j2ykga; Type: FK CONSTRAINT; Schema: public; Owner: -
--
ALTER TABLE ONLY public."HostHistory"
ADD CONSTRAINT fk3d09knnmxrt6iniwnp8j2ykga FOREIGN KEY (history_registrar_id) REFERENCES public."Registrar"(registrar_id);
--
-- Name: SignedMarkRevocationEntry fk5ivlhvs3121yx2li5tqh54u4; Type: FK CONSTRAINT; Schema: public; Owner: -
--
@ -2171,6 +2163,14 @@ ALTER TABLE ONLY public."GracePeriod"
ADD CONSTRAINT fk_grace_period_registrar_id FOREIGN KEY (registrar_id) REFERENCES public."Registrar"(registrar_id);
--
-- Name: HostHistory fk_history_registrar_id; Type: FK CONSTRAINT; Schema: public; Owner: -
--
ALTER TABLE ONLY public."HostHistory"
ADD CONSTRAINT fk_history_registrar_id FOREIGN KEY (history_registrar_id) REFERENCES public."Registrar"(registrar_id) DEFERRABLE INITIALLY DEFERRED;
--
-- Name: Host fk_host_creation_registrar_id; Type: FK CONSTRAINT; Schema: public; Owner: -
--
@ -2208,7 +2208,7 @@ ALTER TABLE ONLY public."Host"
--
ALTER TABLE ONLY public."HostHistory"
ADD CONSTRAINT fk_hosthistory_host FOREIGN KEY (host_repo_id) REFERENCES public."Host"(repo_id);
ADD CONSTRAINT fk_hosthistory_host FOREIGN KEY (host_repo_id) REFERENCES public."Host"(repo_id) DEFERRABLE INITIALLY DEFERRED;
--