zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-14 15:05:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix @VisibleForTesting given the newly deployed enforcement

Browse source 
Generated code is now also covered by @VisibleForTesting, including Dagger @Inject

This CL is a cleanup of auto-generated code by ghm@ from the Error Prone team

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=228748874
This commit is contained in:
guyben 2019-01-10 11:48:28 -08:00 • committed by Ben McIlwain
parent 8bde7285bf
commit c74ffd7559
15 changed files with 11 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/request/auth/LegacyAuthenticationMechanism.java
View file

@ -22,7 +22,6 @@ import static google.registry.security.XsrfTokenManager.P_CSRF_TOKEN;
import static google.registry.security.XsrfTokenManager.X_CSRF_TOKEN;
import com.google.appengine.api.users.UserService;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableSet;
import google.registry.security.XsrfTokenManager;
import javax.inject.Inject;
@ -41,7 +40,6 @@ public class LegacyAuthenticationMechanism implements AuthenticationMechanism {
/** HTTP methods which are considered safe, and do not require XSRF protection. */
private static final ImmutableSet<String> SAFE_METHODS = ImmutableSet.of("GET", "HEAD");
@VisibleForTesting
@Inject
public LegacyAuthenticationMechanism(UserService userService, XsrfTokenManager xsrfTokenManager) {
this.userService = userService;

2
java/google/registry/request/auth/OAuthAuthenticationMechanism.java
View file

@ -22,7 +22,6 @@ import com.google.appengine.api.oauth.OAuthRequestException;
import com.google.appengine.api.oauth.OAuthService;
import com.google.appengine.api.oauth.OAuthServiceFailureException;
import com.google.appengine.api.users.User;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableSet;
import com.google.common.flogger.FluentLogger;
import google.registry.config.RegistryConfig.Config;
@ -50,7 +49,6 @@ public class OAuthAuthenticationMechanism implements AuthenticationMechanism {
private final ImmutableSet<String> allowedOauthClientIds;
@VisibleForTesting
@Inject
public OAuthAuthenticationMechanism(
OAuthService oauthService,

2
java/google/registry/request/auth/RequestAuthenticator.java
View file

@ -17,7 +17,6 @@ package google.registry.request.auth;
import static com.google.common.base.Preconditions.checkArgument;
import com.google.auto.value.AutoValue;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Ordering;
import com.google.common.flogger.FluentLogger;
@ -35,7 +34,6 @@ public class RequestAuthenticator {
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
@VisibleForTesting
@Inject
public RequestAuthenticator(
AppEngineInternalAuthenticationMechanism appEngineInternalAuthenticationMechanism,