Fix some issues caught by IntelliJ static code analysis

The most common issues were:
* Arrays.asList() shouldn't be called with a single parameter.
* Broken Javadoc @links.
* Unnecessary casts and type declarations.
* Unnecessary unused variable initializations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=230994311
This commit is contained in:
mcilwain 2019-01-25 16:53:20 -08:00 committed by Ben McIlwain
parent 3cf26ff9b6
commit c6e58d3bff
39 changed files with 132 additions and 165 deletions

View file

@ -131,7 +131,7 @@ final class ValidateEscrowDepositCommand implements Command {
}
}
System.out.println();
System.out.printf("Contents:\n");
System.out.println("Contents:");
for (Map.Entry<String, Long> count : counts.entrySet()) {
System.out.printf(" - %s: %,d %s\n",
count.getKey(),
@ -158,9 +158,9 @@ final class ValidateEscrowDepositCommand implements Command {
good = false;
}
if (good) {
System.out.printf("RDE deposit is XML schema valid\n");
System.out.println("RDE deposit is XML schema valid");
} else {
System.out.printf("RDE deposit is XML schema valid but has bad references\n");
System.out.println("RDE deposit is XML schema valid but has bad references");
}
}