Fix some issues caught by IntelliJ static code analysis

The most common issues were:
* Arrays.asList() shouldn't be called with a single parameter.
* Broken Javadoc @links.
* Unnecessary casts and type declarations.
* Unnecessary unused variable initializations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=230994311
This commit is contained in:
mcilwain 2019-01-25 16:53:20 -08:00 committed by Ben McIlwain
parent 3cf26ff9b6
commit c6e58d3bff
39 changed files with 132 additions and 165 deletions

View file

@ -43,10 +43,12 @@ final class GetResourceByKeyCommand implements CommandWithRemoteApi {
public void run() {
for (String keyString : mainParameters) {
System.out.println("\n");
Key<EppResource> resourceKey = checkNotNull(
Key.<EppResource>create(keyString), "Could not parse key string: " + keyString);
EppResource resource = checkNotNull(
ofy().load().key(resourceKey).now(), "Could not load resource for key: " + resourceKey);
Key<EppResource> resourceKey =
checkNotNull(Key.create(keyString), "Could not parse key string: " + keyString);
EppResource resource =
checkNotNull(
ofy().load().key(resourceKey).now(),
"Could not load resource for key: " + resourceKey);
System.out.println(expand ? resource.toHydratedString() : resource.toString());
}
}