Fix some issues caught by IntelliJ static code analysis

The most common issues were:
* Arrays.asList() shouldn't be called with a single parameter.
* Broken Javadoc @links.
* Unnecessary casts and type declarations.
* Unnecessary unused variable initializations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=230994311
This commit is contained in:
mcilwain 2019-01-25 16:53:20 -08:00 committed by Ben McIlwain
parent 3cf26ff9b6
commit c6e58d3bff
39 changed files with 132 additions and 165 deletions

View file

@ -369,15 +369,8 @@ public abstract class EppResource extends BackupGroupRoot implements Buildable {
Streams.stream(keys).map(key -> (Key<EppResource>) key).collect(toImmutableList());
// Typing shenanigans are required to return the map with the correct required generic type.
return ofy()
.load()
.keys(typedKeys)
.entrySet()
.stream()
.collect(
ImmutableMap
.<Map.Entry<Key<EppResource>, EppResource>, Key<? extends EppResource>, EppResource>
toImmutableMap(Entry::getKey, Entry::getValue));
return ofy().load().keys(typedKeys).entrySet().stream()
.collect(ImmutableMap.toImmutableMap(Entry::getKey, Entry::getValue));
}
/**

View file

@ -33,11 +33,10 @@ public final class SchemaVersion {
*/
private static SortedSet<Class<?>> getAllPersistedTypes() {
SortedSet<Class<?>> persistedTypes = new TreeSet<>(Ordering.usingToString());
Queue<Class<?>> queue = new ArrayDeque<>();
// Do a breadth-first search for persisted types, starting with @Entity types and expanding each
// ImmutableObject by querying it for all its persisted field types.
persistedTypes.addAll(EntityClasses.ALL_CLASSES);
queue.addAll(persistedTypes);
Queue<Class<?>> queue = new ArrayDeque<>(persistedTypes);
while (!queue.isEmpty()) {
Class<?> clazz = queue.remove();
if (ImmutableObject.class.isAssignableFrom(clazz)) {

View file

@ -60,7 +60,7 @@ abstract class AugmentedDeleter implements Deleter {
@Override
public Result<Void> key(Key<?> key) {
handleDeletion(Arrays.asList(key));
handleDeletion(ImmutableList.of(key));
return delegate.keys(key);
}

View file

@ -28,7 +28,7 @@ import javax.xml.bind.annotation.XmlNsForm;
import javax.xml.bind.annotation.XmlSchema;
import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
/**
/*
* This package defines all entities which are managed via EPP XML and persisted to the Datastore
* via Objectify.
*