zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add loadWithMemcache() to Ofy

Browse source 
Also clean up some minor uses of load() to standardize calls.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=154067731
This commit is contained in:
cgoldfeder 2017-04-24 10:47:31 -07:00 • committed by Ben McIlwain
parent c1643fa3cd
commit c596d23523
2 changed files with 24 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/backup/DeleteOldCommitLogsAction.java
View file

@ -136,7 +136,7 @@ public final class DeleteOldCommitLogsAction implements Runnable {
private boolean doesEnoughDataExistThatThisTaskIsWorthRunning() { private boolean doesEnoughDataExistThatThisTaskIsWorthRunning() {
int tenth = Math.max(1, maxDeletes / 10); int tenth = Math.max(1, maxDeletes / 10);
int count = queryManifests(ofy.loadEventuallyConsistent()) int count = queryManifests(ofy.load())
.limit(tenth) .limit(tenth)
.count(); .count();
if (0 < count && count < tenth) { if (0 < count && count < tenth) {

28
java/google/registry/model/ofy/Ofy.java
View file

@ -25,7 +25,6 @@ import static google.registry.util.ObjectifyUtils.OBJECTS_TO_KEYS;
import com.google.appengine.api.datastore.DatastoreFailureException; import com.google.appengine.api.datastore.DatastoreFailureException;
import com.google.appengine.api.datastore.DatastoreTimeoutException; import com.google.appengine.api.datastore.DatastoreTimeoutException;
import com.google.appengine.api.datastore.ReadPolicy.Consistency;
import com.google.appengine.api.taskqueue.TransientFailureException; import com.google.appengine.api.taskqueue.TransientFailureException;
import com.google.common.annotations.VisibleForTesting; import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableMap;
@ -121,12 +120,31 @@ public class Ofy {
checkState(inTransaction(), "Must be called in a transaction"); checkState(inTransaction(), "Must be called in a transaction");
} }
/**
* Load from Datastore, bypassing memcache even when the results might be there.
*
* <p>In general, this is the correct method to use for loads. Loading from memcache can, in rare
* instances, produce a stale result (when a memcache write fails and the previous result is not
* cleared out) and so using memcache should be avoided unless the caller can tolerate staleness
* until the memcache expiration time and there is a specific need for very low latency that is
* worth the extra complexity of reasoning about caching.
*/
public Loader load() { public Loader load() {
return ofy().load(); // TODO(b/27424173): change to false when memcache audit changes are implemented.
return ofy().cache(true).load();
} }
public Loader loadEventuallyConsistent() { /**
return ofy().consistency(Consistency.EVENTUAL).load(); * Load from Datastore, bypassing memcache even when the results might be there.
*
* <p>In general, prefer {@link #load} over this method. Loading from memcache can, in rare
* instances, produce a stale result (when a memcache write fails and the previous result is not
* cleared out) and so using memcache should be avoided unless the caller can tolerate staleness
* until the memcache expiration time and there is a specific need for very low latency that is
* worth the extra complexity of reasoning about caching.
*/
public Loader loadWithMemcache() {
return ofy().cache(true).load();
} }
/** /**
@ -267,7 +285,7 @@ public class Ofy {
} }
return Objects.equals( return Objects.equals(
union(work.getMutations(), manifest), union(work.getMutations(), manifest),
ImmutableSet.copyOf(ofy().load().ancestor(manifest))); ImmutableSet.copyOf(load().ancestor(manifest)));
}}); }});
} }