diff --git a/java/google/registry/flows/Flow.java b/java/google/registry/flows/Flow.java index 41c067087..ba627528c 100644 --- a/java/google/registry/flows/Flow.java +++ b/java/google/registry/flows/Flow.java @@ -59,14 +59,6 @@ public abstract class Flow { /** Execute the business logic for this flow. */ protected abstract EppOutput run() throws EppException; - /** - * Subclasses that create a resource should override this to return the repoId of the new - * resource. - */ - protected String getCreatedRepoId() { - return null; - } - protected String getClientId() { return sessionMetadata.getClientId(); } diff --git a/java/google/registry/flows/FlowRunner.java b/java/google/registry/flows/FlowRunner.java index 574d11976..34c9162b2 100644 --- a/java/google/registry/flows/FlowRunner.java +++ b/java/google/registry/flows/FlowRunner.java @@ -128,7 +128,6 @@ public class FlowRunner { } }); logger.info("EPP_Mutation_Committed " + new JsonLogStatement(trid) - .add("createdRepoId", flowResult.getResponse().getCreatedRepoId()) .add("executionTime", flowResult.getResponse().getExecutionTime().getMillis())); return flowResult; } catch (DryRunException e) { @@ -165,9 +164,6 @@ public class FlowRunner { * *

An example output for an EPP_Mutation_Committed that doesn't create a new resource: * {"trid":"abc-123", "executionTime":123456789} - * - *

An example output for an EPP_Mutation_Committed that creates a new resource: - * {"trid":"abc-123", "executionRepoId":123, "executionTime":123456789} */ private static class JsonLogStatement { diff --git a/java/google/registry/flows/ResourceCreateFlow.java b/java/google/registry/flows/ResourceCreateFlow.java index bd2071796..7799893cc 100644 --- a/java/google/registry/flows/ResourceCreateFlow.java +++ b/java/google/registry/flows/ResourceCreateFlow.java @@ -88,11 +88,6 @@ public abstract class ResourceCreateFlow modifyCreateRelatedResources(); } - @Override - protected final String getCreatedRepoId() { - return newResource.getRepoId(); - } - /** Modify any other resources that need to be informed of this create. */ protected void modifyCreateRelatedResources() {} diff --git a/java/google/registry/model/eppoutput/EppResponse.java b/java/google/registry/model/eppoutput/EppResponse.java index ec67b252a..e46f79e7c 100644 --- a/java/google/registry/model/eppoutput/EppResponse.java +++ b/java/google/registry/model/eppoutput/EppResponse.java @@ -99,14 +99,6 @@ public class EppResponse extends ImmutableObject implements ResponseOrGreeting { @XmlTransient DateTime executionTime; - /** - * The repository id of a new object if this is a create response, or null. - * - *

This is for logging purposes only and is not returned to the user. - */ - @XmlTransient - String createdRepoId; - /** * Information about messages queued for retrieval. This may appear in response to any EPP message * (if messages are queued), but in practice this will only be set in response to a poll request. @@ -170,10 +162,6 @@ public class EppResponse extends ImmutableObject implements ResponseOrGreeting { return executionTime; } - public String getCreatedRepoId() { - return createdRepoId; - } - public ImmutableList getResponseData() { return resData; } @@ -238,11 +226,6 @@ public class EppResponse extends ImmutableObject implements ResponseOrGreeting { return this; } - public Builder setCreatedRepoId(String createdRepoId) { - getInstance().createdRepoId = createdRepoId; - return this; - } - public Builder setResData(@Nullable ImmutableList resData) { getInstance().resData = resData; return this; diff --git a/javatests/google/registry/flows/FlowRunnerTest.java b/javatests/google/registry/flows/FlowRunnerTest.java index b11dd8459..9a6651044 100644 --- a/javatests/google/registry/flows/FlowRunnerTest.java +++ b/javatests/google/registry/flows/FlowRunnerTest.java @@ -69,7 +69,6 @@ public class FlowRunnerTest extends ShardableTestCase { final EppOutput eppOutput = mock(EppOutput.class); EppResponse eppResponse = mock(EppResponse.class); - when(eppResponse.getCreatedRepoId()).thenReturn("foo"); when(eppResponse.getExecutionTime()).thenReturn(new DateTime(1337)); when(eppOutput.getResponse()).thenReturn(eppResponse);