diff --git a/javatests/google/registry/flows/domain/DomainInfoFlowTest.java b/javatests/google/registry/flows/domain/DomainInfoFlowTest.java index 85d1e72c8..bbc4ea291 100644 --- a/javatests/google/registry/flows/domain/DomainInfoFlowTest.java +++ b/javatests/google/registry/flows/domain/DomainInfoFlowTest.java @@ -25,6 +25,7 @@ import static google.registry.testing.DatastoreHelper.persistActiveHost; import static google.registry.testing.DatastoreHelper.persistResource; import static google.registry.testing.EppExceptionSubject.assertAboutEppExceptions; import static google.registry.testing.JUnitBackports.assertThrows; +import static google.registry.testing.TestDataHelper.updateSubstitutions; import com.google.common.base.Predicates; import com.google.common.collect.ImmutableMap; @@ -62,6 +63,18 @@ import org.junit.Test; /** Unit tests for {@link DomainInfoFlow}. */ public class DomainInfoFlowTest extends ResourceFlowTestCase { + /** + * The domain_info_fee.xml default substitutions common to most tests. + * + *

It doesn't set a default value to the COMMAND and PERIOD keys, because they are different in + * every test. + */ + private static final ImmutableMap SUBSTITUTION_BASE = + ImmutableMap.of( + "NAME", "example.tld", + "CURRENCY", "USD", + "UNIT", "y"); + private ContactResource registrant; private ContactResource contact; private HostResource host1; @@ -130,9 +143,12 @@ public class DomainInfoFlowTest extends ResourceFlowTestCase substitutions) + throws Exception { assertTransactionalFlow(false); - String expected = loadFile(expectedXmlFilename, ImmutableMap.of("ROID", "2FF-TLD")); + String expected = + loadFile(expectedXmlFilename, updateSubstitutions(substitutions, "ROID", "2FF-TLD")); if (inactive) { expected = expected.replaceAll("\"ok\"", "\"inactive\""); } @@ -141,6 +157,10 @@ public class DomainInfoFlowTest extends ResourceFlowTestCase - example.tld + %NAME% %CURRENCY% - create - 2 + %COMMAND% + %PERIOD% ABC-12345 diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_bad_period.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_bad_period.xml deleted file mode 100644 index dcff208dc..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_bad_period.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - example.tld - - - - - USD - create - 2 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_create_premium.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_create_premium.xml deleted file mode 100644 index 9c6adb682..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_create_premium.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - rich.example - - - - - USD - create - 1 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_create_premium_response.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_create_premium_response.xml deleted file mode 100644 index 2f46c23f8..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_create_premium_response.xml +++ /dev/null @@ -1,47 +0,0 @@ - - - - Command completed successfully - - - - rich.example - %ROID% - - jd1234 - sh8013 - sh8013 - - ns1.example.tld - ns1.example.net - - ns1.example.tld - ns2.example.tld - NewRegistrar - TheRegistrar - 1999-04-03T22:00:00.0Z - NewRegistrar - 1999-12-03T09:00:00.0Z - 2005-04-03T22:00:00.0Z - 2000-04-08T09:00:00.0Z - - 2fooBAR - - - - - - USD - create - 1 - 100.00 - premium - - - - ABC-12345 - server-trid - - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_multiyear_restore.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_multiyear_restore.xml deleted file mode 100644 index ce13a78d6..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_multiyear_restore.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - example.tld - - - - - USD - restore - 2 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_multiyear_transfer.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_multiyear_transfer.xml deleted file mode 100644 index fc7538fd1..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_multiyear_transfer.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - example.tld - - - - - USD - transfer - 2 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_premium_response.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_premium_response.xml similarity index 93% rename from javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_premium_response.xml rename to javatests/google/registry/flows/domain/testdata/domain_info_fee_premium_response.xml index 30da5352b..5ed534d36 100644 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_premium_response.xml +++ b/javatests/google/registry/flows/domain/testdata/domain_info_fee_premium_response.xml @@ -33,9 +33,9 @@ USD - transfer + %COMMAND% 1 - 100.00 + 100.00 premium diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew.xml deleted file mode 100644 index 5dcdca427..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - example.tld - - - - - USD - renew - 2 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_premium.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_premium.xml deleted file mode 100644 index 10fb44f6f..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_premium.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - rich.example - - - - - USD - renew - 1 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_premium_response.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_premium_response.xml deleted file mode 100644 index 09d4e9924..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_premium_response.xml +++ /dev/null @@ -1,47 +0,0 @@ - - - - Command completed successfully - - - - rich.example - %ROID% - - jd1234 - sh8013 - sh8013 - - ns1.example.tld - ns1.example.net - - ns1.example.tld - ns2.example.tld - NewRegistrar - TheRegistrar - 1999-04-03T22:00:00.0Z - NewRegistrar - 1999-12-03T09:00:00.0Z - 2005-04-03T22:00:00.0Z - 2000-04-08T09:00:00.0Z - - 2fooBAR - - - - - - USD - renew - 1 - 100.00 - premium - - - - ABC-12345 - server-trid - - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_response.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_response.xml deleted file mode 100644 index a2c9e9fd1..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_renew_response.xml +++ /dev/null @@ -1,46 +0,0 @@ - - - - Command completed successfully - - - - example.tld - %ROID% - - jd1234 - sh8013 - sh8013 - - ns1.example.tld - ns1.example.net - - ns1.example.tld - ns2.example.tld - NewRegistrar - TheRegistrar - 1999-04-03T22:00:00.0Z - NewRegistrar - 1999-12-03T09:00:00.0Z - 2005-04-03T22:00:00.0Z - 2000-04-08T09:00:00.0Z - - 2fooBAR - - - - - - USD - renew - 2 - 22.00 - - - - ABC-12345 - server-trid - - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_create_response.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_response.xml similarity index 91% rename from javatests/google/registry/flows/domain/testdata/domain_info_fee_create_response.xml rename to javatests/google/registry/flows/domain/testdata/domain_info_fee_response.xml index 2d3117af4..f6091f2da 100644 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_create_response.xml +++ b/javatests/google/registry/flows/domain/testdata/domain_info_fee_response.xml @@ -33,9 +33,9 @@ USD - create - 2 - 26.00 + %COMMAND% + %PERIOD% + %FEE% diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_restore.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_restore.xml deleted file mode 100644 index 7e60b3b5b..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_restore.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - example.tld - - - - - USD - restore - 1 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_restore_premium.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_restore_premium.xml deleted file mode 100644 index 4c724644d..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_restore_premium.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - rich.example - - - - - USD - restore - 1 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer.xml deleted file mode 100644 index d68f8a3fa..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - example.tld - - - - - USD - transfer - 1 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_premium.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_premium.xml deleted file mode 100644 index 000798d4d..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_premium.xml +++ /dev/null @@ -1,18 +0,0 @@ - - - - - rich.example - - - - - USD - transfer - 1 - - - ABC-12345 - - diff --git a/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_response.xml b/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_response.xml deleted file mode 100644 index 731c7ce21..000000000 --- a/javatests/google/registry/flows/domain/testdata/domain_info_fee_transfer_response.xml +++ /dev/null @@ -1,46 +0,0 @@ - - - - Command completed successfully - - - - example.tld - %ROID% - - jd1234 - sh8013 - sh8013 - - ns1.example.tld - ns1.example.net - - ns1.example.tld - ns2.example.tld - NewRegistrar - TheRegistrar - 1999-04-03T22:00:00.0Z - NewRegistrar - 1999-12-03T09:00:00.0Z - 2005-04-03T22:00:00.0Z - 2000-04-08T09:00:00.0Z - - 2fooBAR - - - - - - USD - transfer - 1 - 11.00 - - - - ABC-12345 - server-trid - - -