zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Refactor GetEppResourceCommand hierarchy

Browse source 
This refactors the GetEppResourceCommand hierarchy a bit so that instead of
using the type param on the class to do implicit loading (which doesn't
work that well any more for domain applications anyway), we just do the
loading in each child class and rely on the parent class only for printing
and setting common flags.

I did this to make it possible for loadByForeignKey() to have strong typing
(in a future CL), but I think this changes stands on its own merits for
making the logic here more straightforward and actually somewhat shorter.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=134115072
This commit is contained in:
nickfelt 2016-09-23 14:05:22 -07:00 • committed by Ben McIlwain
parent 9dde013066
commit c3723bfa2f
8 changed files with 50 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

8
javatests/google/registry/tools/GetApplicationCommandTest.java
View file

@ -70,20 +70,20 @@ public class GetApplicationCommandTest extends CommandTestCase<GetApplicationCom
persistResource(
newDomainApplication("example.tld").asBuilder().setDeletionTime(now.plusDays(1)).build());
runCommand("--read_timestamp=" + now.plusMonths(1), "2-TLD");
assertInStdout("DomainApplication '2-TLD' does not exist or is deleted");
assertInStdout("Application '2-TLD' does not exist or is deleted");
}
@Test
public void testSuccess_deletedApplication() throws Exception {
persistDeletedDomainApplication("example.tld", now);
runCommand("2-TLD");
assertInStdout("DomainApplication '2-TLD' does not exist or is deleted");
assertInStdout("Application '2-TLD' does not exist or is deleted");
}
@Test
public void testSuccess_applicationDoesNotExist() throws Exception {
runCommand("42-TLD");
assertInStdout("DomainApplication '42-TLD' does not exist or is deleted");
assertInStdout("Application '42-TLD' does not exist or is deleted");
}
@Test
@ -99,6 +99,6 @@ public class GetApplicationCommandTest extends CommandTestCase<GetApplicationCom
runCommand("2-TLD", "4-TLD", "55-TLD");
assertInStdout("fullyQualifiedDomainName=example.tld");
assertInStdout("fullyQualifiedDomainName=example2.tld");
assertInStdout("DomainApplication '55-TLD' does not exist or is deleted");
assertInStdout("Application '55-TLD' does not exist or is deleted");
}
}