zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-12 22:38:16 +02:00
Code Issues Projects Releases Packages Wiki Activity

Refactor GetEppResourceCommand hierarchy

Browse source 
This refactors the GetEppResourceCommand hierarchy a bit so that instead of
using the type param on the class to do implicit loading (which doesn't
work that well any more for domain applications anyway), we just do the
loading in each child class and rely on the parent class only for printing
and setting common flags.

I did this to make it possible for loadByForeignKey() to have strong typing
(in a future CL), but I think this changes stands on its own merits for
making the logic here more straightforward and actually somewhat shorter.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=134115072
This commit is contained in:
nickfelt 2016-09-23 14:05:22 -07:00 • committed by Ben McIlwain
parent 9dde013066
commit c3723bfa2f
8 changed files with 50 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

12
java/google/registry/tools/GetApplicationIdsCommand.java
View file

@ -17,6 +17,7 @@ package google.registry.tools;
import static google.registry.model.index.DomainApplicationIndex.loadActiveApplicationsByDomainName;
import static google.registry.model.registry.Registries.assertTldExists;
import static google.registry.model.registry.Registries.findTldForNameOrThrow;
import static org.joda.time.DateTimeZone.UTC;
import com.beust.jcommander.Parameter;
import com.beust.jcommander.Parameters;
@ -26,12 +27,12 @@ import google.registry.model.domain.DomainApplication;
import google.registry.tools.Command.GtechCommand;
import google.registry.tools.Command.RemoteApiCommand;
import java.util.List;
import org.joda.time.DateTime;
/** Command to generate a list of all applications for a given domain name(s). */
@Parameters(separators = " =",
commandDescription = "Generate list of application IDs and sponsors for given domain name(s)")
final class GetApplicationIdsCommand extends GetEppResourceCommand<DomainApplication>
implements RemoteApiCommand, GtechCommand {
final class GetApplicationIdsCommand implements RemoteApiCommand, GtechCommand {
@Parameter(
description = "Fully qualified domain name(s)",
@ -39,10 +40,7 @@ final class GetApplicationIdsCommand extends GetEppResourceCommand<DomainApplica
private List<String> mainParameters;
@Override
void processParameters() {
// Note that this function explicitly performs its own resource load and print, ignoring
// GetEppResourceCommand.printResource(), because we do NOT want to display the entire
// application to gTech users -- just the ID# and sponsor.
public void run() {
for (String domainName : mainParameters) {
InternetDomainName tld = findTldForNameOrThrow(InternetDomainName.from(domainName));
assertTldExists(tld.toString());
@ -55,7 +53,7 @@ final class GetApplicationIdsCommand extends GetEppResourceCommand<DomainApplica
// example2.tld:
// No applications exist for 'example2.tld'.
ImmutableList<DomainApplication> applications = ImmutableList.copyOf(
loadActiveApplicationsByDomainName(domainName, readTimestamp));
loadActiveApplicationsByDomainName(domainName, DateTime.now(UTC)));
if (applications.isEmpty()) {
System.out.printf(" No applications exist for \'%s\'.%n", domainName);
} else {