zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-23 19:20:44 +02:00
Code Issues Projects Releases Packages Wiki Activity

Stop invoking npm when formatting Java (#2075)

Browse source 
Move console-webapp:(check,apply)Formatting tasks the task graph so that
the Java formatting tasks do not have to invoke npm.
This commit is contained in:
Weimin Yu 2023-07-13 11:30:33 -04:00 • committed by GitHub
parent 304e7c9726
commit c33d2cb0b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
build.gradle
View file

@ -516,7 +516,6 @@ task javaIncrementalFormatCheck {
println("Omitting format check: not in a git directory.") println("Omitting format check: not in a git directory.")
} }
} }
dependsOn('console-webapp:checkFormatting')
} }
// Shows how modified lines in Java source files will change after formatting. // Shows how modified lines in Java source files will change after formatting.
@ -534,7 +533,6 @@ task javaIncrementalFormatApply {
doLast { doLast {
invokeJavaDiffFormatScript("format") invokeJavaDiffFormatScript("format")
} }
dependsOn('console-webapp:applyFormatting')
} }
task javadoc(type: Javadoc) { task javadoc(type: Javadoc) {
@ -561,6 +559,7 @@ tasks.build.dependsOn(tasks.javadoc)
// core Nomulus codebase, and runs all presubmits. // core Nomulus codebase, and runs all presubmits.
task coreDev { task coreDev {
dependsOn 'javaIncrementalFormatApply' dependsOn 'javaIncrementalFormatApply'
dependsOn 'console-webapp:applyFormatting'
dependsOn 'javadoc' dependsOn 'javadoc'
dependsOn 'checkDependenciesDotGradle' dependsOn 'checkDependenciesDotGradle'
dependsOn 'checkLicense' dependsOn 'checkLicense'

1
console-webapp/build.gradle
View file

@ -66,3 +66,4 @@ tasks.runConsoleWebappUnitTests.dependsOn(tasks.npmInstallDeps)
tasks.buildConsoleWebappProd.dependsOn(tasks.npmInstallDeps) tasks.buildConsoleWebappProd.dependsOn(tasks.npmInstallDeps)
tasks.applyFormatting.dependsOn(tasks.npmInstallDeps) tasks.applyFormatting.dependsOn(tasks.npmInstallDeps)
tasks.checkFormatting.dependsOn(tasks.npmInstallDeps) tasks.checkFormatting.dependsOn(tasks.npmInstallDeps)
tasks.build.dependsOn(tasks.checkFormatting)