Add unlock fields to RegistryLocks (#408)

* Add unlock fields to RegistryLocks

This will make it easier to reason around inter-connected registry lock
objects (like when we add dependent roids). It will make it easier to
answer the question of "Have all locks associated with this host/contact
roid been unlocked?", as well as the question of "Was the last lock
object associated with this domain unlocked?"

* Responses to CR

* Make the DAO API more specific

* whoops, undo rename

db/src/main/resources/sql/flyway/V13__refactor_registry_lock.sql

@@ -0,0 +1,22 @@
+-- Copyright 2019 The Nomulus Authors. All Rights Reserved.
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+ALTER TABLE "RegistryLock" DROP COLUMN action;
+
+ALTER TABLE "RegistryLock" ADD COLUMN unlock_request_timestamp timestamptz;
+ALTER TABLE "RegistryLock" ADD COLUMN unlock_completion_timestamp timestamptz;
+ALTER TABLE "RegistryLock" ADD COLUMN last_update_timestamp timestamptz;
+
+ALTER TABLE "RegistryLock" RENAME creation_timestamp TO lock_request_timestamp;
+ALTER TABLE "RegistryLock" RENAME completion_timestamp TO lock_completion_timestamp;

db/src/main/resources/sql/schema/db-schema.sql.generated

@@ -148,14 +148,16 @@
 
     create table "RegistryLock" (
        revision_id  bigserial not null,
-        action text not null,
-        completion_timestamp timestamptz,
-        creation_timestamp timestamptz not null,
         domain_name text not null,
         is_superuser boolean not null,
+        last_update_timestamp timestamptz,
+        lock_completion_timestamp timestamptz,
+        lock_request_timestamp timestamptz not null,
         registrar_id text not null,
         registrar_poc_id text,
         repo_id text not null,
+        unlock_completion_timestamp timestamptz,
+        unlock_request_timestamp timestamptz,
         verification_code text not null,
         primary key (revision_id)
     );

db/src/main/resources/sql/schema/nomulus.golden.sql

@@ -122,15 +122,17 @@ ALTER SEQUENCE public."PremiumList_revision_id_seq" OWNED BY public."PremiumList
 
 CREATE TABLE public."RegistryLock" (
     revision_id bigint NOT NULL,
-    action text NOT NULL,
-    completion_timestamp timestamp with time zone,
-    creation_timestamp timestamp with time zone NOT NULL,
+    lock_completion_timestamp timestamp with time zone,
+    lock_request_timestamp timestamp with time zone NOT NULL,
     domain_name text NOT NULL,
     is_superuser boolean NOT NULL,
     registrar_id text NOT NULL,
     registrar_poc_id text,
     repo_id text NOT NULL,
-    verification_code text NOT NULL
+    verification_code text NOT NULL,
+    unlock_request_timestamp timestamp with time zone,
+    unlock_completion_timestamp timestamp with time zone,
+    last_update_timestamp timestamp with time zone
 );