zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 00:47:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Switch from Guava Optionals to Java 8 Optionals

Browse source 
This was a surprisingly involved change. Some of the difficulties included
java.util.Optional purposely not being Serializable (so I had to move a
few Optionals in mapreduce classes to @Nullable) and having to add the Truth
Java8 extension library for assertion support.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=171863777
This commit is contained in:
mcilwain 2017-10-11 13:09:26 -07:00 • committed by jianglai
parent 184b2b56ac
commit c0f8da0c6e
581 changed files with 1325 additions and 932 deletions
Download patch file Download diff file Expand all files Collapse all files

4
java/google/registry/whois/DomainLookupCommand.java
View file

@ -16,9 +16,9 @@ package google.registry.whois;
import static google.registry.model.EppResourceUtils.loadByForeignKey;
import com.google.common.base.Optional;
import com.google.common.net.InternetDomainName;
import google.registry.model.domain.DomainResource;
import java.util.Optional;
import org.joda.time.DateTime;
/** Represents a WHOIS lookup on a domain name (i.e. SLD). */
@ -32,7 +32,7 @@ public class DomainLookupCommand extends DomainOrHostLookupCommand {
protected Optional<WhoisResponse> getResponse(InternetDomainName domainName, DateTime now) {
final DomainResource domainResource =
loadByForeignKey(DomainResource.class, domainName.toString(), now);
return Optional.<WhoisResponse>fromNullable(
return Optional.<WhoisResponse>ofNullable(
domainResource == null ? null : new DomainWhoisResponse(domainResource, now));
}
}