zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-01 23:42:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add TODOs regarding cloud sql database name change (#1005)

Browse source 
* Add TODOs regarding cloud sql database name change

We should choose a different database name for nomulus data since using
'postgres' is bad practice. See b/181693544 more background.

We have decided to delay the db change to the time when we upgrade
postgresql version. This PR adds TODOs to all occurrences of the jdbcUrl
property, including those in the internal-repo. This property will change
when we upgrade, so the TODOs will be noticed.
This commit is contained in:
Weimin Yu 2021-03-12 09:34:13 -05:00 • committed by GitHub
parent 1d9f67ac70
commit bf5ac3a327
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/src/main/java/google/registry/config/files/default-config.yaml
View file

@ -225,6 +225,10 @@ hibernate:
cloudSql:
# jdbc url for the Cloud SQL database.
# TODO(b/181693544): change the database name when upgrading postgres version
# Using the default 'postgres' is bad practice. See bug for more information.
# If jdbcUrl in this file is moved elsewhere, be sure to move this notice
# with it until the change is applied.
jdbcUrl: jdbc:postgresql://localhost
# Username for the database user.
username: username