zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Make domain check return availability regardless of fee extensions

Browse source 
This allows a registrar to check domain availability even if the fee extension is not set. To obtain the premium price or create the domain, the fee extension is still needed.

PS: I believe the previous tests are erroneous anyway. It is the presence of fee extensions in the check request that we were looking for. Checking if the extension is declared during login has no bearing on the results.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=192778137
This commit is contained in:
jianglai 2018-04-13 09:17:16 -07:00
parent 078e9cbe53
commit bee77f0cc3
2 changed files with 2 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

7
java/google/registry/flows/domain/DomainCheckFlow.java
View file

@ -26,7 +26,6 @@ import static google.registry.flows.domain.DomainFlowUtils.verifyNotInPredelegat
import static google.registry.model.EppResourceUtils.checkResourcesExist;
import static google.registry.model.index.DomainApplicationIndex.loadActiveApplicationsByDomainName;
import static google.registry.model.registry.label.ReservationType.getTypeOfHighestSeverity;
import static google.registry.pricing.PricingEngineProxy.isDomainPremium;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
@ -199,12 +198,6 @@ public final class DomainCheckFlow implements Flow {
return Optional.of("Pending allocation");
}
ImmutableSet<ReservationType> reservationTypes = getReservationTypes(domainName);
if (reservationTypes.isEmpty()
&& isDomainPremium(domainName.toString(), now)
&& registry.getPremiumPriceAckRequired()
&& !eppInput.getSingleExtension(FeeCheckCommandExtension.class).isPresent()) {
return Optional.of("Premium names require EPP ext.");
}
if (!reservationTypes.isEmpty()) {
return Optional.of(getTypeOfHighestSeverity(reservationTypes).getMessageForCheck());
}