From b9742adc0bb8de698a62eb3bf9c97fc2be4c092a Mon Sep 17 00:00:00 2001
From: Lai Jiang <jianglai@google.com>
Date: Thu, 23 Mar 2023 14:29:06 -0400
Subject: [PATCH] Delete cron.xml (#1965)

We've successfully migrated to using Cloud Scheduler.
---
 .../java/google/registry/env/alpha/default/WEB-INF/cron.xml  | 5 -----
 .../java/google/registry/env/crash/default/WEB-INF/cron.xml  | 5 -----
 .../google/registry/env/production/default/WEB-INF/cron.xml  | 4 ----
 .../java/google/registry/env/qa/default/WEB-INF/cron.xml     | 5 -----
 .../env/sandbox/default/WEB-INF/cloud-scheduler-tasks.xml    | 3 ---
 release/cloudbuild-deploy.yaml                               | 2 +-
 6 files changed, 1 insertion(+), 23 deletions(-)
 delete mode 100644 core/src/main/java/google/registry/env/alpha/default/WEB-INF/cron.xml
 delete mode 100644 core/src/main/java/google/registry/env/crash/default/WEB-INF/cron.xml
 delete mode 100644 core/src/main/java/google/registry/env/production/default/WEB-INF/cron.xml
 delete mode 100644 core/src/main/java/google/registry/env/qa/default/WEB-INF/cron.xml

diff --git a/core/src/main/java/google/registry/env/alpha/default/WEB-INF/cron.xml b/core/src/main/java/google/registry/env/alpha/default/WEB-INF/cron.xml
deleted file mode 100644
index 9ab88efce..000000000
--- a/core/src/main/java/google/registry/env/alpha/default/WEB-INF/cron.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--TODO: ptkach - Remove this file after cloud scheduler is fully up and running -->
-<cronentries>
-
-</cronentries>
diff --git a/core/src/main/java/google/registry/env/crash/default/WEB-INF/cron.xml b/core/src/main/java/google/registry/env/crash/default/WEB-INF/cron.xml
deleted file mode 100644
index 9ab88efce..000000000
--- a/core/src/main/java/google/registry/env/crash/default/WEB-INF/cron.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--TODO: ptkach - Remove this file after cloud scheduler is fully up and running -->
-<cronentries>
-
-</cronentries>
diff --git a/core/src/main/java/google/registry/env/production/default/WEB-INF/cron.xml b/core/src/main/java/google/registry/env/production/default/WEB-INF/cron.xml
deleted file mode 100644
index 288444fa4..000000000
--- a/core/src/main/java/google/registry/env/production/default/WEB-INF/cron.xml
+++ /dev/null
@@ -1,4 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--TODO: ptkach - Remove this file after cloud scheduler is fully up and running -->
-<cronentries>
-</cronentries>
diff --git a/core/src/main/java/google/registry/env/qa/default/WEB-INF/cron.xml b/core/src/main/java/google/registry/env/qa/default/WEB-INF/cron.xml
deleted file mode 100644
index 9ab88efce..000000000
--- a/core/src/main/java/google/registry/env/qa/default/WEB-INF/cron.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--TODO: ptkach - Remove this file after cloud scheduler is fully up and running -->
-<cronentries>
-
-</cronentries>
diff --git a/core/src/main/java/google/registry/env/sandbox/default/WEB-INF/cloud-scheduler-tasks.xml b/core/src/main/java/google/registry/env/sandbox/default/WEB-INF/cloud-scheduler-tasks.xml
index 430ce0218..63c9a9ffc 100644
--- a/core/src/main/java/google/registry/env/sandbox/default/WEB-INF/cloud-scheduler-tasks.xml
+++ b/core/src/main/java/google/registry/env/sandbox/default/WEB-INF/cloud-scheduler-tasks.xml
@@ -11,9 +11,6 @@
     <!--
       This only needs to run once per day, but we launch additional jobs in case the
       cursor is lagging behind, so it'll catch up to the current date eventually.
-
-      See <a href="../../../production/default/WEB-INF/cron.xml">production config</a> for an
-      explanation of job starting times.
     -->
     <schedule>7 */12 * * *</schedule>
   </task>
diff --git a/release/cloudbuild-deploy.yaml b/release/cloudbuild-deploy.yaml
index 2f84aa878..8708dea2a 100644
--- a/release/cloudbuild-deploy.yaml
+++ b/release/cloudbuild-deploy.yaml
@@ -59,7 +59,7 @@ steps:
     else
       project_id="domain-registry-${_ENV}"
     fi
-    for filename in cron dispatch queue; do
+    for filename in dispatch queue; do
       gcloud -q --project $project_id app deploy \
         default/WEB-INF/appengine-generated/$filename.yaml
     done