diff --git a/java/google/registry/ui/forms/FormField.java b/java/google/registry/ui/forms/FormField.java index 7b6e9f6ab..1d3878e44 100644 --- a/java/google/registry/ui/forms/FormField.java +++ b/java/google/registry/ui/forms/FormField.java @@ -266,9 +266,7 @@ public final class FormField { /** Ensure value is not {@code null}. */ public Builder required() { - @SuppressWarnings("unchecked") - Function requiredFunction = (Function) REQUIRED_FUNCTION; - return transform(requiredFunction); + return transform(Builder::checkNotNullTransform); } /** @@ -280,17 +278,12 @@ public final class FormField { public Builder emptyToNull() { checkState(CharSequence.class.isAssignableFrom(typeOut) || Collection.class.isAssignableFrom(typeOut)); - @SuppressWarnings("unchecked") - Function emptyToNullFunction = - (Function) - ((Function) - input -> - ((input instanceof CharSequence) && (((CharSequence) input).length() == 0)) - || ((input instanceof Collection) - && ((Collection) input).isEmpty()) - ? null - : input); - return transform(emptyToNullFunction); + return transform( + input -> + ((input instanceof CharSequence) && (((CharSequence) input).length() == 0)) + || ((input instanceof Collection) && ((Collection) input).isEmpty()) + ? null + : input); } /** @@ -560,13 +553,12 @@ public final class FormField { return new FormField<>(name, typeIn, typeOut, converter); } - private static final Function REQUIRED_FUNCTION = - input -> { - if (input == null) { - throw new FormFieldException("This field is required."); - } - return input; - }; + private static O checkNotNullTransform(@Nullable O input) { + if (input == null) { + throw new FormFieldException("This field is required."); + } + return input; + } private static final class DefaultFunction implements Function { private final O defaultValue;