zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 16:37:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Don't use modules to instantiate classes

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=132380251
This commit is contained in:
jart 2016-09-06 17:09:40 -07:00 • committed by Ben McIlwain
parent 697098602e
commit b77ebd1df9
3 changed files with 10 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

1
java/google/registry/module/backend/BackendComponent.java
View file

@ -47,7 +47,6 @@ import javax.inject.Singleton;
@Component(
modules = {
AppIdentityCredentialModule.class,
BackendMetricsModule.class,
BigqueryModule.class,
ConfigModule.class,
DatastoreServiceModule.class,

34
java/google/registry/module/backend/BackendMetricsModule.java
View file

@ -1,34 +0,0 @@
// Copyright 2016 The Domain Registry Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package google.registry.module.backend;
import dagger.Module;
import dagger.Provides;
import google.registry.dns.DnsMetrics;
import javax.inject.Singleton;
/**
* Dagger module for injecting metrics. All metrics should have {@link Singleton} scope to avoid
* being recreated per-request, as the metrics generally track cumulative values.
*/
@Module
public class BackendMetricsModule {
@Provides
@Singleton
static DnsMetrics provideDnsMetrics() {
return new DnsMetrics();
}
}