zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-31 06:56:28 +02:00
Code Issues Projects Releases Packages Wiki Activity

Build Nomulus with Java 17 (#2255)

Browse source 
This PR makes it possible to build the Nomulus code base using Java 17.
Building with Java 11 continue to be possible and the resulting bytecodes are
still at Java 8 level. Also upgraded Gradle to 8.5.

There are several necessary changes to make this happen:

1. Some Gradle plugins need to be upgraded to support Java 17, notably
errorprone. As a result, a lot more "errors" were caught and corrected.

2. All test code are now built and run at Java 8 level. Previously it was left
undefined (which defaults to the version of the compiler) and had led to
situations where we inadvertently called Java 8+ features in production that
are not caught by tests. The change also made the java8compatibility subproject
obsolete, which is therefore removed.

3. Removed the docs subproject. Its main use is to generate flows.md, but it
relies heavily on Java internal APIs that have changed significant with each
version. Upgrading to Java 11 required extensive refactoring of the code there,
and Java 17 again removed many APIs that were used. I don't think it is worth
the maintenance effort just to have a tool to generate flows.md which no one
actually reads.

4. Capped a few GCP dependencies because the latest version depends on
 grpc-java >= 1.59.0, which includes a runtime incompatibility
 (https://github.com/grpc/grpc-java/releases/tag/v1.59.0).
This commit is contained in:
Lai Jiang 2024-01-09 15:56:37 -05:00 • committed by GitHub
parent e79c63142a
commit b5d2b56426
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
134 changed files with 750 additions and 3731 deletions
Download patch file Download diff file Expand all files Collapse all files

56
java_common.gradle
View file

@ -71,8 +71,8 @@ configurations {
}
dependencies {
// compatibility with Java 8
errorprone("com.google.errorprone:error_prone_core:2.3.4")
// compatibility with Java 17
errorprone("com.google.errorprone:error_prone_core:2.23.0")
}
test {
@ -109,27 +109,37 @@ tasks.withType(Test).configureEach {
}
tasks.withType(JavaCompile).configureEach {
// The -Werror flag causes Intellij to fail on deprecated api use.
// Allow IDE user to turn off this flag by specifying a Gradle VM
// option from inside the IDE.
if (System.getProperty('no_werror') != 'true' &&
// The core project throws an warning about Gradle annotation processor
// not compatible with Java source version > 8. Re-assess once the
// warning is fixed.
getProject().name != 'core') {
options.compilerArgs << "-Werror"
}
options.errorprone.disableWarningsInGeneratedCode = true
options.errorprone.errorproneArgumentProviders.add([
asArguments: {
return ['-XepExcludedPaths:.*/build/generated/.*']
}] as CommandLineArgumentProvider)
// Disable features currently incompatible with Java 12
if ((JavaVersion.current().majorVersion as Integer) > 11) {
// This check is broken in Java 12.
// See https://github.com/google/error-prone/issues/1257
options.errorprone.errorproneArgs=['-Xep:Finally:OFF']
}
// The -Werror flag causes Intellij to fail on deprecated api use.
// Allow IDE user to turn off this flag by specifying a Gradle VM
// option from inside the IDE.
if (System.getProperty('no_werror') != 'true') {
options.compilerArgs << "-Werror"
}
if (name.equals('compileTestJava')) {
// Allow unused methods in tests.
options.errorprone.disable("UnusedMethod")
// Allow unused variables in tests.
options.errorprone.disable("UnusedVariable")
}
// Allow using non-constant strings in log.
options.errorprone.disable("FloggerLogString")
// Allow using @error in javadoc.
options.errorprone.disable("InvalidBlockTag")
// Allow creating format string as single-use variables.
options.errorprone.disable("InlineFormatString")
// TODO: enable this check once we fix all existing violations.
options.errorprone.disable("NullableOptional")
// Allow implicit cast from long to double.
options.errorprone.disable("LongDoubleConversion")
// Allow import of commonly-used names such as "Type".
options.errorprone.disable("BadImport")
// TODO: enable this once we are on Java 17 runtime.
options.errorprone.disable("InlineMeInliner")
options.errorprone.disableWarningsInGeneratedCode = true
options.errorprone.errorproneArgumentProviders.add([
asArguments: {
return ['-XepExcludedPaths:.*/build/generated/.*']
}] as CommandLineArgumentProvider)
}
compileJava { options.encoding = "UTF-8" }