Fix some statically detected code issues

This includes: unnecessary semicolons, suppress warnings, switch statements, final/private qualifiers, Optional wrapping, conditionals, both inline and non-inline variables, ternaries, Collection putAll() calls, StringBuilders, and throws declarations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244182539
This commit is contained in:
mcilwain 2019-04-18 07:34:10 -07:00 committed by jianglai
parent 2c049a65b0
commit b46a6b6d55
54 changed files with 107 additions and 158 deletions

View file

@ -24,7 +24,6 @@ import google.registry.testing.AppEngineRule;
import google.registry.tools.LevelDbFileBuilder.Property;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.IOException;
import org.junit.Rule;
import org.junit.Test;
@ -41,7 +40,7 @@ public class LevelDbFileBuilderTest {
@Rule public final AppEngineRule appEngine = AppEngineRule.builder().withDatastore().build();
@Test
public void testSingleRecordWrites() throws FileNotFoundException, IOException {
public void testSingleRecordWrites() throws IOException {
File subdir = tempFs.newFolder("folder");
File logFile = new File(subdir, "testfile");
LevelDbFileBuilder builder = new LevelDbFileBuilder(logFile);
@ -64,7 +63,7 @@ public class LevelDbFileBuilderTest {
}
@Test
public void testMultipleRecordWrites() throws FileNotFoundException, IOException {
public void testMultipleRecordWrites() throws IOException {
File subdir = tempFs.newFolder("folder");
File logFile = new File(subdir, "testfile");
LevelDbFileBuilder builder = new LevelDbFileBuilder(logFile);