zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-28 13:51:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix some statically detected code issues

Browse source 
This includes: unnecessary semicolons, suppress warnings, switch statements, final/private qualifiers, Optional wrapping, conditionals, both inline and non-inline variables, ternaries, Collection putAll() calls, StringBuilders, and throws declarations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244182539
This commit is contained in:
mcilwain 2019-04-18 07:34:10 -07:00 • committed by jianglai
parent 2c049a65b0
commit b46a6b6d55
54 changed files with 107 additions and 158 deletions
Download patch file Download diff file Expand all files Collapse all files

3
java/google/registry/tools/RegistrarContactCommand.java
View file

@ -307,8 +307,7 @@ final class RegistrarContactCommand extends MutatingCommand {
private void unsetOtherWhoisAbuseFlags(
ImmutableSet<RegistrarContact> contacts, @Nullable String emailAddressNotToChange) {
for (RegistrarContact contact : contacts) {
if (((emailAddressNotToChange == null)
|| !contact.getEmailAddress().equals(emailAddressNotToChange))
if (!contact.getEmailAddress().equals(emailAddressNotToChange)
&& contact.getVisibleInDomainWhoisAsAbuse()) {
RegistrarContact newContact =
contact.asBuilder().setVisibleInDomainWhoisAsAbuse(false).build();