zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove toString() method on Result.Code and fix metrics recording

Browse source 
We almost certainly had intended to record a String representation of the
numeric Code all along, but a bad toString() method on the enum resulted
in the wrong thing happening.  This is more evidence of why overriding
toString() on enums is bad.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=133583683
This commit is contained in:
mcilwain 2016-07-31 07:44:42 -04:00 • committed by Ben McIlwain
parent aa2af68af0
commit b1e1dd0f47
2 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
java/google/registry/model/eppoutput/Result.java
View file

@ -150,11 +150,6 @@ public class Result extends ImmutableObject {
public boolean isSuccess() {
return code < 2000;
}
@Override
public String toString() {
return String.format("{code:'%s', msg:'%s', msgLang:'%s'}", code, msg, msgLang);
}
}
/** The result code for this result. This is always present. */