zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-12 23:44:46 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix small naming issue in a test (#685)

Browse source
This commit is contained in:
gbrodman 2020-07-14 13:57:44 -04:00 • committed by GitHub
parent 20cd587409
commit b0f43c814c
1 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

24
core/src/test/java/google/registry/model/registry/label/ReservedListSqlDaoTest.java
View file

@ -41,31 +41,31 @@ public class ReservedListSqlDaoTest {
JpaIntegrationWithCoverageExtension jpa = JpaIntegrationWithCoverageExtension jpa =
new JpaTestRules.Builder().withClock(fakeClock).buildIntegrationWithCoverageExtension(); new JpaTestRules.Builder().withClock(fakeClock).buildIntegrationWithCoverageExtension();
private ImmutableMap<String, ReservedListEntry> test_reservations; private ImmutableMap<String, ReservedListEntry> testReservations;
private ReservedList test_reserved_list; private ReservedList testReservedList;
@BeforeEach @BeforeEach
void setUp() { void setUp() {
test_reservations = testReservations =
ImmutableMap.of( ImmutableMap.of(
"food", "food",
ReservedListEntry.create("food", ReservationType.RESERVED_FOR_SPECIFIC_USE, null), ReservedListEntry.create("food", ReservationType.RESERVED_FOR_SPECIFIC_USE, null),
"music", "music",
ReservedListEntry.create("music", ReservationType.FULLY_BLOCKED, "fully blocked")); ReservedListEntry.create("music", ReservationType.FULLY_BLOCKED, "fully blocked"));
test_reserved_list = testReservedList =
new ReservedList.Builder() new ReservedList.Builder()
.setName("testlist") .setName("testlist")
.setLastUpdateTime(fakeClock.nowUtc()) .setLastUpdateTime(fakeClock.nowUtc())
.setShouldPublish(false) .setShouldPublish(false)
.setReservedListMap(test_reservations) .setReservedListMap(testReservations)
.build(); .build();
} }
@Test @Test
public void save_worksSuccessfully() { public void save_worksSuccessfully() {
ReservedListSqlDao.save(test_reserved_list); ReservedListSqlDao.save(testReservedList);
jpaTm() jpaTm()
.transact( .transact(
() -> { () -> {
@ -76,7 +76,7 @@ public class ReservedListSqlDaoTest {
.setParameter("name", "testlist") .setParameter("name", "testlist")
.getSingleResult(); .getSingleResult();
assertThat(persistedList.getReservedListEntries()) assertThat(persistedList.getReservedListEntries())
.containsExactlyEntriesIn(test_reservations); .containsExactlyEntriesIn(testReservations);
assertThat(persistedList.getLastUpdateTime()).isEqualTo(fakeClock.nowUtc()); assertThat(persistedList.getLastUpdateTime()).isEqualTo(fakeClock.nowUtc());
}); });
} }
@ -84,20 +84,20 @@ public class ReservedListSqlDaoTest {
@Test @Test
public void checkExists_worksSuccessfully() { public void checkExists_worksSuccessfully() {
assertThat(ReservedListSqlDao.checkExists("testlist")).isFalse(); assertThat(ReservedListSqlDao.checkExists("testlist")).isFalse();
ReservedListSqlDao.save(test_reserved_list); ReservedListSqlDao.save(testReservedList);
assertThat(ReservedListSqlDao.checkExists("testlist")).isTrue(); assertThat(ReservedListSqlDao.checkExists("testlist")).isTrue();
} }
@Test @Test
public void getLatestRevision_worksSuccessfully() { public void getLatestRevision_worksSuccessfully() {
assertThat(ReservedListSqlDao.getLatestRevision("testlist").isPresent()).isFalse(); assertThat(ReservedListSqlDao.getLatestRevision("testlist").isPresent()).isFalse();
ReservedListSqlDao.save(test_reserved_list); ReservedListSqlDao.save(testReservedList);
ReservedList persistedList = ReservedListSqlDao.getLatestRevision("testlist").get(); ReservedList persistedList = ReservedListSqlDao.getLatestRevision("testlist").get();
assertThat(persistedList.getRevisionId()).isNotNull(); assertThat(persistedList.getRevisionId()).isNotNull();
assertThat(persistedList.getLastUpdateTime()).isEqualTo(fakeClock.nowUtc()); assertThat(persistedList.getLastUpdateTime()).isEqualTo(fakeClock.nowUtc());
assertThat(persistedList.getName()).isEqualTo("testlist"); assertThat(persistedList.getName()).isEqualTo("testlist");
assertThat(persistedList.getShouldPublish()).isFalse(); assertThat(persistedList.getShouldPublish()).isFalse();
assertThat(persistedList.getReservedListEntries()).containsExactlyEntriesIn(test_reservations); assertThat(persistedList.getReservedListEntries()).containsExactlyEntriesIn(testReservations);
} }
@Test @Test
@ -113,12 +113,12 @@ public class ReservedListSqlDaoTest {
ReservedListEntry.create( ReservedListEntry.create(
"old", ReservationType.RESERVED_FOR_SPECIFIC_USE, null))) "old", ReservationType.RESERVED_FOR_SPECIFIC_USE, null)))
.build()); .build());
ReservedListSqlDao.save(test_reserved_list); ReservedListSqlDao.save(testReservedList);
ReservedList persistedList = ReservedListSqlDao.getLatestRevision("testlist").get(); ReservedList persistedList = ReservedListSqlDao.getLatestRevision("testlist").get();
assertThat(persistedList.getRevisionId()).isNotNull(); assertThat(persistedList.getRevisionId()).isNotNull();
assertThat(persistedList.getLastUpdateTime()).isEqualTo(fakeClock.nowUtc()); assertThat(persistedList.getLastUpdateTime()).isEqualTo(fakeClock.nowUtc());
assertThat(persistedList.getName()).isEqualTo("testlist"); assertThat(persistedList.getName()).isEqualTo("testlist");
assertThat(persistedList.getShouldPublish()).isFalse(); assertThat(persistedList.getShouldPublish()).isFalse();
assertThat(persistedList.getReservedListEntries()).containsExactlyEntriesIn(test_reservations); assertThat(persistedList.getReservedListEntries()).containsExactlyEntriesIn(testReservations);
} }
} }