zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use more efficient logging statements

Browse source 
The infofmt versions only perform string concatenation if info logging
is turned on, rather than doing so all of the time.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172889338
This commit is contained in:
mcilwain 2017-10-20 08:55:59 -07:00 • committed by jianglai
parent 15e03a8b1a
commit b01fa6b4c9
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
java/google/registry/backup/RestoreCommitLogsAction.java
View file

@ -100,7 +100,7 @@ public class RestoreCommitLogsAction implements Runnable {
Map<Integer, DateTime> bucketTimestamps = new HashMap<>(); Map<Integer, DateTime> bucketTimestamps = new HashMap<>();
CommitLogCheckpoint lastCheckpoint = null; CommitLogCheckpoint lastCheckpoint = null;
for (GcsFileMetadata metadata : diffFiles) { for (GcsFileMetadata metadata : diffFiles) {
logger.info("Restoring: " + metadata.getFilename().getObjectName()); logger.infofmt("Restoring: %s", metadata.getFilename().getObjectName());
try (InputStream input = Channels.newInputStream( try (InputStream input = Channels.newInputStream(
gcsService.openPrefetchingReadChannel(metadata.getFilename(), 0, BLOCK_SIZE))) { gcsService.openPrefetchingReadChannel(metadata.getFilename(), 0, BLOCK_SIZE))) {
PeekingIterator<ImmutableObject> commitLogs = PeekingIterator<ImmutableObject> commitLogs =
@ -160,7 +160,7 @@ public class RestoreCommitLogsAction implements Runnable {
private void saveRaw(final List<Entity> entitiesToSave) { private void saveRaw(final List<Entity> entitiesToSave) {
if (dryRun) { if (dryRun) {
logger.info("Would have saved " + entitiesToSave); logger.infofmt("Would have saved entities: %s", entitiesToSave);
return; return;
} }
retry(() -> datastoreService.put(entitiesToSave)); retry(() -> datastoreService.put(entitiesToSave));
@ -168,7 +168,7 @@ public class RestoreCommitLogsAction implements Runnable {
private void saveOfy(final Iterable<? extends ImmutableObject> objectsToSave) { private void saveOfy(final Iterable<? extends ImmutableObject> objectsToSave) {
if (dryRun) { if (dryRun) {
logger.info("Would have saved " + asList(objectsToSave)); logger.infofmt("Would have saved entities: %s", objectsToSave);
return; return;
} }
retry(() -> ofy().saveWithoutBackup().entities(objectsToSave).now()); retry(() -> ofy().saveWithoutBackup().entities(objectsToSave).now());
@ -176,7 +176,7 @@ public class RestoreCommitLogsAction implements Runnable {
private Result<?> deleteAsync(Set<Key<?>> keysToDelete) { private Result<?> deleteAsync(Set<Key<?>> keysToDelete) {
if (dryRun) { if (dryRun) {
logger.info("Would have deleted " + keysToDelete); logger.infofmt("Would have deleted entities: %s", keysToDelete);
} }
return dryRun || keysToDelete.isEmpty() return dryRun || keysToDelete.isEmpty()
? new ResultNow<Void>(null) ? new ResultNow<Void>(null)