Remove final on @ParametersDelegate field

Compile-time constant inlining may interfere with JCommander's processing if a field is made final - @ParametersDelegate fields are particularly misleading.  Remove the one instance of that and add warning comments elsewhere.  See

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136469351
This commit is contained in:
nickfelt 2016-10-18 07:14:23 -07:00 committed by Ben McIlwain
parent e127920f20
commit afa4d66601
3 changed files with 5 additions and 1 deletions

View file

@ -21,6 +21,7 @@ import google.registry.bigquery.BigqueryConnection;
abstract class BigqueryCommand implements Command { abstract class BigqueryCommand implements Command {
/** Parameter delegate for encapsulating flags needed to set up the {@link BigqueryConnection}. */ /** Parameter delegate for encapsulating flags needed to set up the {@link BigqueryConnection}. */
// Do not make this final - compile-time constant inlining may interfere with JCommander.
@ParametersDelegate @ParametersDelegate
private BigqueryParameters bigqueryParameters = new BigqueryParameters(); private BigqueryParameters bigqueryParameters = new BigqueryParameters();

View file

@ -36,8 +36,9 @@ import org.joda.time.format.DateTimeFormatter;
@Parameters(separators = " =", commandDescription = "Generates a registrar activity report.") @Parameters(separators = " =", commandDescription = "Generates a registrar activity report.")
final class RegistrarActivityReportCommand implements Command { final class RegistrarActivityReportCommand implements Command {
// Do not make this final - compile-time constant inlining may interfere with JCommander.
@ParametersDelegate @ParametersDelegate
private final BigqueryParameters bigqueryParameters = new BigqueryParameters(); private BigqueryParameters bigqueryParameters = new BigqueryParameters();
@Parameter( @Parameter(
names = {"-t", "--tld"}, names = {"-t", "--tld"},

View file

@ -42,9 +42,11 @@ final class RegistryCli {
description = "Sets the default environment to run the command.") description = "Sets the default environment to run the command.")
private RegistryToolEnvironment environment = RegistryToolEnvironment.PRODUCTION; private RegistryToolEnvironment environment = RegistryToolEnvironment.PRODUCTION;
// Do not make this final - compile-time constant inlining may interfere with JCommander.
@ParametersDelegate @ParametersDelegate
private AppEngineConnection connection = new AppEngineConnection(); private AppEngineConnection connection = new AppEngineConnection();
// Do not make this final - compile-time constant inlining may interfere with JCommander.
@ParametersDelegate @ParametersDelegate
private LoggingParameters loggingParams = new LoggingParameters(); private LoggingParameters loggingParams = new LoggingParameters();