zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove all vestiges of memcache

Browse source 
Memcache is already off but now it's not in the code anymore.

This includes removing domain creation failfast, since that is actually
slower now than just running the flow - all you gain is a non-transactional
read over a transactional read, but the cost is that you always pay that
read, which is going to drive up latency.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158183506
This commit is contained in:
cgoldfeder 2017-06-06 13:43:42 -07:00 • committed by Ben McIlwain
parent 445faab977
commit ae039aa0d8
37 changed files with 29 additions and 341 deletions
Download patch file Download diff file Expand all files Collapse all files

32
java/google/registry/model/EppResourceUtils.java
View file

@ -24,7 +24,6 @@ import static google.registry.util.DateTimeUtils.latestOf;
import com.google.common.base.Function;
import com.googlecode.objectify.Key;
import com.googlecode.objectify.Result;
import com.googlecode.objectify.cmd.Loader;
import com.googlecode.objectify.cmd.Query;
import com.googlecode.objectify.util.ResultNow;
import google.registry.model.EppResource.Builder;
@ -93,41 +92,16 @@ public final class EppResourceUtils {
@Nullable
public static <T extends EppResource> T loadByForeignKey(
Class<T> clazz, String foreignKey, DateTime now) {
return loadByForeignKeyInternal(clazz, foreignKey, now, false);
}
/**
* Loads the last created version of an {@link EppResource} from Datastore or memcache.
*
* <p>In general, prefer {@link #loadByForeignKey} over this method. Loading from memcache can, in
* rare instances, produce a stale result (when a memcache write fails and the previous result is
* not cleared out) and so using memcache should be avoided unless the caller can tolerate
* staleness until the memcache expiration time and there is a specific need for very low latency
* that is worth the extra complexity of reasoning about caching.
*
* @param clazz the resource type to load
* @param foreignKey id to match
* @param now the current logical time to project resources at
*/
@Nullable
public static <T extends EppResource> T loadByForeignKeyWithMemcache(
Class<T> clazz, String foreignKey, DateTime now) {
return loadByForeignKeyInternal(clazz, foreignKey, now, true);
}
@Nullable
private static <T extends EppResource> T loadByForeignKeyInternal(
Class<T> clazz, String foreignKey, DateTime now, boolean useMemcache) {
checkArgument(
ForeignKeyedEppResource.class.isAssignableFrom(clazz),
"loadByForeignKey may only be called for foreign keyed EPP resources");
Loader loader = useMemcache ? ofy().loadWithMemcache() : ofy().load();
ForeignKeyIndex<T> fki = loader.type(ForeignKeyIndex.mapToFkiClass(clazz)).id(foreignKey).now();
ForeignKeyIndex<T> fki =
ofy().load().type(ForeignKeyIndex.mapToFkiClass(clazz)).id(foreignKey).now();
// The value of fki.getResourceKey() might be null for hard-deleted prober data.
if (fki == null || isAtOrAfter(now, fki.getDeletionTime()) || fki.getResourceKey() == null) {
return null;
}
T resource = loader.key(fki.getResourceKey()).now();
T resource = ofy().load().key(fki.getResourceKey()).now();
if (resource == null || isAtOrAfter(now, resource.getDeletionTime())) {
return null;
}